Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update port-helper-attribute-field.js #1141

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

cecilialam
Copy link
Contributor

Allow the placeholder attribute in the AttributeField class. This is for adding the Placeholder to the table summary text field in the Aloha toolbar.

@GenticsDev
Copy link
Contributor

test

cecilialam added a commit to cecilialam/Aloha-Editor that referenced this pull request Mar 24, 2014
This is related to Update port-helper-attribute-field.js alohaeditor#1141. I am adding a placeholder message to the Table Summary textbox on the toolbar.
@Jotschi
Copy link
Contributor

Jotschi commented Mar 26, 2014

test this please

@GenticsDev
Copy link
Contributor

✘ Test failed.
Refer to this link for build results: http://jenkins.office:8080/job/alohaeditor-upstream-pullrequests/82/

@Jotschi
Copy link
Contributor

Jotschi commented Mar 27, 2014

The repository timeout test failed. This might be a glitch. I'll rerun the tests.

@Jotschi
Copy link
Contributor

Jotschi commented Mar 27, 2014

test this please

@GenticsDev
Copy link
Contributor

✔ Test passed.
Refer to this link for build results: http://jenkins.office:8080/job/alohaeditor-upstream-pullrequests/83/

@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants