Resolve "Fix bugs related to Web FTP" #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to insufficient permissions, the process was unable to access the alpamon.conf file. As a workaround, Fix args to direct pass ServerURL to args.
During single file uploads, a panic was triggered when cmd.Run() was unexpectedly invoked, causing the application to crash. To address this, fix the logic to ensure cmd.Run() is only called when bulk or recursive flags are explicitly set to true.
The process was failing because unzip command was being executed prematurely, before the zip file was created. Fix this by changing | to &&, ensuring that unzip command only runs after the zip file has been successfully generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #10, The following bugs in the Web FTP system have been addressed:
The system does not support Korean characters in file paths.
Downloading large ZIP files is failing.
Downloading specific files causes a panic.
The system is unable to load settings for the FtpClient.
An error occurs during Alpamon installation due to the requirement to select Yes/No.