feat(runner): add ping/pong handler for WebSocket heartbeat #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SendPongResponse() method to handle explicit ping queries - Handle "ping" query in CommandRequestHandler with pong response - Remove automatic ping on every message read
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the WebSocket heartbeat mechanism by replacing automatic ping-on-read with an explicit ping/pong handler pattern. The server can now send explicit ping requests, and the runner will respond with timestamped pong responses.
- Adds
SendPongResponse()method to send pong responses with timestamps - Implements ping query handler in
CommandRequestHandlerto respond to server pings - Removes automatic ping sending after every message read to rely on explicit ping/pong instead
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
…ility - Support legacy servers that send ping as command instead of query - Add cmd/alpamon/alpamon to gitignore
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SendPongResponse()method to handle explicit ping queries from serverCommandRequestHandlerwith pong response including timestampTest plan
{"query": "ping"}and receive{"query": "pong", "timestamp": "..."}SendPongResponse()method