Fix prevent log recursion, retry CheckSession, and skip reporter on full queue #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royroyee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses multiple critical issues related to logging, session handling, and queue management:
Logging Fix: Prevented recursive log forwarding to the remote server by introducing file-based filtering using
logRecordFileHandlers. Unregistered files are ignored, and logs below the specified severity level are skipped.Session Fix: Corrected
CheckSessionto retry on invalid responses instead of returning false, improving session request reliability.Queue Fix: Added error handling to prevent waking up the reporter goroutine when the queue is full, avoiding unnecessary processing and potential deadlocks.