refactor(logger): remove lumberjack, use systemd journald for logging #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove lumberjack dependency for log rotation - Output logs to stderr for systemd/journald to capture - Update systemd service to use journald (StandardOutput/Error=journal) - Add log viewing instructions to README
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the logging mechanism to use systemd's journald instead of application-level log rotation with lumberjack, following Linux-native logging conventions.
- Removes the lumberjack dependency and file-based logging
- Redirects all logs to stderr for systemd/journald capture
- Updates systemd service configuration to properly integrate with journald
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/logger/logger.go | Simplified InitLogger() to write to stderr instead of files; removed lumberjack configuration and return value |
| cmd/alpamon/command/root.go | Updated gracefulShutdown() signature and all call sites to remove lumberjack logger parameter and cleanup logic |
| go.mod | Removed lumberjack dependency from module requirements |
| go.sum | Removed lumberjack dependency checksums |
| configs/alpamon.service | Configured StandardOutput/StandardError to use journald with SyslogIdentifier |
| README.md | Added comprehensive documentation for viewing logs using journalctl commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
geunwoonoh
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Why
Follow Linux-native logging conventions. Let systemd/journald handle log collection and rotation instead of application-level log rotation with lumberjack.
Test plan
journalctl -u alpamon -f/var/log/alpamon/alpamon.log