-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed "traits" namespace to "trait" #1651
Conversation
I am against removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not check every file, but I think trusting the CI is fine in this case.
The commit was made with @tonydp03 as author. @psychocoderHPC do you insist on commiting under the Tools author? And @j-stephan do you want @tonydp03 to update all the copyright headers? I don't care much about both of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bernhardmgruber mentioned it please commit your changes with
GIT_AUTHOR_NAME="Tools" GIT_AUTHOR_EMAIL="[email protected]" git commit ...
This PR is mostly processed with search and replace. We try to submit automated changes under an generic user.
If we have the tools author I don't think we need to update the copyright header. |
I'll change the headers, rebase, and squash the new commit with the previous one under the Tools author. |
Fixes #179. The Alpaka namespace "traits" was renamed to "trait" in all its occurrencies. However, are we sure we want to keep the namespace and not removing it entirely to simplify the code, as @bernhardmgruber suggested?