-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: refactor and extend atomic tests #1772
Draft
psychocoderHPC
wants to merge
4
commits into
alpaka-group:develop
Choose a base branch
from
psychocoderHPC:fix-atomics
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,143 @@ | ||
/* Copyright 2022 Axel Huebl, Benjamin Worpitz, Matthias Werner, Jan Stephan, Bernhard Manfred Gruber, | ||
* Antonio Di Pilato | ||
* | ||
* This file is part of alpaka. | ||
* | ||
* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this | ||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
*/ | ||
|
||
//! @file This file provides functors where a atomic function and the corresponding operation availble within one | ||
//! object. This allwos testing of the atomic function and atomicOp<Op>() without the usage of function pointers whcih | ||
//! is not suppoted by all backends. | ||
|
||
#include <alpaka/atomic/Op.hpp> | ||
#include <alpaka/atomic/Traits.hpp> | ||
|
||
#include <utility> | ||
|
||
namespace alpaka::test::unit::atomic | ||
{ | ||
struct Add | ||
{ | ||
using Op = alpaka::AtomicAdd; | ||
|
||
template<typename... TArgs> | ||
static ALPAKA_FN_ACC auto atomic(TArgs&&... args) | ||
{ | ||
return alpaka::atomicAdd(std::forward<TArgs>(args)...); | ||
} | ||
}; | ||
|
||
struct Sub | ||
{ | ||
using Op = alpaka::AtomicSub; | ||
|
||
template<typename... TArgs> | ||
static ALPAKA_FN_ACC auto atomic(TArgs&&... args) | ||
{ | ||
return alpaka::atomicSub(std::forward<TArgs>(args)...); | ||
} | ||
}; | ||
|
||
struct Min | ||
{ | ||
using Op = alpaka::AtomicMin; | ||
|
||
template<typename... TArgs> | ||
static ALPAKA_FN_ACC auto atomic(TArgs&&... args) | ||
{ | ||
return alpaka::atomicMin(std::forward<TArgs>(args)...); | ||
} | ||
}; | ||
|
||
struct Max | ||
{ | ||
using Op = alpaka::AtomicMax; | ||
|
||
template<typename... TArgs> | ||
static ALPAKA_FN_ACC auto atomic(TArgs&&... args) | ||
{ | ||
return alpaka::atomicMax(std::forward<TArgs>(args)...); | ||
} | ||
}; | ||
|
||
struct Exch | ||
{ | ||
using Op = alpaka::AtomicExch; | ||
|
||
template<typename... TArgs> | ||
static ALPAKA_FN_ACC auto atomic(TArgs&&... args) | ||
{ | ||
return alpaka::atomicExch(std::forward<TArgs>(args)...); | ||
} | ||
}; | ||
|
||
struct Dec | ||
{ | ||
using Op = alpaka::AtomicDec; | ||
|
||
template<typename... TArgs> | ||
static ALPAKA_FN_ACC auto atomic(TArgs&&... args) | ||
{ | ||
return alpaka::atomicDec(std::forward<TArgs>(args)...); | ||
} | ||
}; | ||
|
||
struct Inc | ||
{ | ||
using Op = alpaka::AtomicInc; | ||
|
||
template<typename... TArgs> | ||
static ALPAKA_FN_ACC auto atomic(TArgs&&... args) | ||
{ | ||
return alpaka::atomicInc(std::forward<TArgs>(args)...); | ||
} | ||
}; | ||
|
||
struct Cas | ||
{ | ||
using Op = alpaka::AtomicCas; | ||
|
||
template<typename... TArgs> | ||
static ALPAKA_FN_ACC auto atomic(TArgs&&... args) | ||
{ | ||
return alpaka::atomicCas(std::forward<TArgs>(args)...); | ||
} | ||
}; | ||
|
||
struct Or | ||
{ | ||
using Op = alpaka::AtomicOr; | ||
|
||
template<typename... TArgs> | ||
static ALPAKA_FN_ACC auto atomic(TArgs&&... args) | ||
{ | ||
return alpaka::atomicOr(std::forward<TArgs>(args)...); | ||
} | ||
}; | ||
|
||
struct Xor | ||
{ | ||
using Op = alpaka::AtomicXor; | ||
|
||
template<typename... TArgs> | ||
static ALPAKA_FN_ACC auto atomic(TArgs&&... args) | ||
{ | ||
return alpaka::atomicXor(std::forward<TArgs>(args)...); | ||
} | ||
}; | ||
|
||
struct And | ||
{ | ||
using Op = alpaka::AtomicAnd; | ||
|
||
template<typename... TArgs> | ||
static ALPAKA_FN_ACC auto atomic(TArgs&&... args) | ||
{ | ||
return alpaka::atomicAnd(std::forward<TArgs>(args)...); | ||
} | ||
}; | ||
|
||
} // namespace alpaka::test::unit::atomic |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkelling found out that this variadic template usage is the root of the nvhpc error (invalid memory access)