Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement alpaka::meta::isList, alpaka::meta::ToList and alpaka::meta::toTuple #2269

Merged
merged 1 commit into from
May 28, 2024
Merged

implement alpaka::meta::isList, alpaka::meta::ToList and alpaka::meta::toTuple #2269

merged 1 commit into from
May 28, 2024

Conversation

SimeonEhrig
Copy link
Member

@SimeonEhrig SimeonEhrig commented May 13, 2024 •
edited
Loading

  • alpaka::meta::isTuple: checks if a given type is a std::tuple or not

  • alpaka::meta::toTuple: pack a arbitrary number of types in a std::tuple. If the given type is a std::tuple the created type is the same.

  • check if it working with PR [WIP] implement memory visibility #2180 , because the function is used there

@SimeonEhrig SimeonEhrig added this to the 1.2.0 milestone May 13, 2024
@SimeonEhrig SimeonEhrig marked this pull request as ready for review May 13, 2024 19:56
@SimeonEhrig SimeonEhrig marked this pull request as draft May 14, 2024 14:18
@SimeonEhrig SimeonEhrig changed the title implement alpaka::meta::isTuple and alpaka::meta::toTuple implement alpaka::meta::isTuple, alpaka::meta::toTuple and alpaka::meta::toUniqueTypeTuple May 14, 2024
@SimeonEhrig SimeonEhrig marked this pull request as ready for review May 14, 2024 14:58
@SimeonEhrig SimeonEhrig changed the title implement alpaka::meta::isTuple, alpaka::meta::toTuple and alpaka::meta::toUniqueTypeTuple implement alpaka::meta::isList, alpaka::meta::ToList and alpaka::meta::toTuple May 15, 2024
@SimeonEhrig SimeonEhrig marked this pull request as draft May 15, 2024 14:04
@psychocoderHPC
Copy link
Member

@SimeonEhrig please update the description of this PR, isTuple,... is not valid anymore.

psychocoderHPC
psychocoderHPC requested changes May 16, 2024
View reviewed changes
Copy link
Member

@psychocoderHPC psychocoderHPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ONly one name change is required and maybe a small comment extension.

include/alpaka/meta/TypeListOps.hpp Show resolved Hide resolved
include/alpaka/meta/TypeListOps.hpp Outdated Show resolved Hide resolved
@SimeonEhrig
11;rgb:1818/1818/1818# This is the 1st commit message:
a70c990 
implement alpaka::meta::isList and alpaka::meta::toList

- `alpaka::meta::isList` checks a given type is a type list
- `alpaka::meta::toList` checks if a given type is a type list and if not, create a type list with all given types
@SimeonEhrig SimeonEhrig marked this pull request as ready for review May 16, 2024 14:18
@psychocoderHPC psychocoderHPC merged commit f226dce into alpaka-group:develop May 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychocoderHPC psychocoderHPC psychocoderHPC approved these changes

Assignees
No one assigned
Labels
Type:Enhancement
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SimeonEhrig @psychocoderHPC