Str 1781 impl evm ee #1127

purusang · 2025-11-05T16:40:30Z

Description

It is a work heavily based on strata-proofimpl-evm-ee-stf/src/executor.rs::process_block() and used tons of help from Claude understanding the traits, process_block() function, evm data types, .... and to generate code.
Thanks!

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Refactor
New or updated tests
Dependency Update

Notes to Reviewers

Checklist

I have performed a self-review of my code.
I have commented my code where necessary.
I have updated the documentation if needed.
My changes do not introduce new warnings.
I have added (where necessary) tests that prove my changes are effective or that my feature works.
New and existing tests pass with my changes.
I have disclosed my use of AI
in the body of this PR.

Related Issues

STR-1781

github-actions · 2025-11-05T17:09:12Z

Commit: 8057953

SP1 Execution Results

program	cycles	success
EVM EE STF	1,303,832	✅
CL STF	211,071	✅
Checkpoint	2,242	✅

codecov · 2025-11-05T17:13:34Z

Codecov Report

❌ Patch coverage is 72.83825% with 267 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.78%. Comparing base (e2c9878) to head (fdf7d37).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/evm-ee/src/codec_shims.rs	56.20%	67 Missing ⚠️
crates/evm-ee/src/execution.rs	58.38%	62 Missing ⚠️
crates/evm-ee/src/types/partial_state.rs	54.88%	60 Missing ⚠️
crates/evm-ee/src/types/witness_db.rs	39.08%	53 Missing ⚠️
crates/evm-ee/src/types/block.rs	42.85%	8 Missing ⚠️
crates/evm-ee/src/types/write_batch.rs	85.71%	6 Missing ⚠️
crates/evm-ee/src/types/block_body.rs	92.98%	4 Missing ⚠️
crates/evm-ee/src/types/tests.rs	97.77%	3 Missing ⚠️
crates/reth/evm/src/utils.rs	90.32%	3 Missing ⚠️
crates/evm-ee/src/utils.rs	99.23%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main    #1127      +/-   ##
==========================================
- Coverage   76.03%   75.78%   -0.26%     
==========================================
  Files         530      544      +14     
  Lines       44666    45682    +1016     
==========================================
+ Hits        33962    34619     +657     
- Misses      10704    11063     +359

Flag	Coverage Δ
functional	`50.53% <75.75%> (-0.66%)`	⬇️
unit	`56.52% <71.51%> (+0.37%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...rates/ee-acct-runtime/src/chain_segment_builder.rs	`93.02% <ø> (ø)`
crates/evm-ee/src/types/header.rs	`100.00% <100.00%> (ø)`
crates/proof-impl/evm-ee-stf/src/executor.rs	`92.40% <100.00%> (-0.37%)`	⬇️
crates/reth/node/src/payload_builder.rs	`77.01% <100.00%> (-11.56%)`	⬇️
crates/simple-ee/src/execution.rs	`98.94% <100.00%> (+0.01%)`	⬆️
crates/evm-ee/src/utils.rs	`99.23% <99.23%> (ø)`
crates/evm-ee/src/types/tests.rs	`97.77% <97.77%> (ø)`
crates/reth/evm/src/utils.rs	`85.00% <90.32%> (-3.89%)`	⬇️
crates/evm-ee/src/types/block_body.rs	`92.98% <92.98%> (ø)`
crates/evm-ee/src/types/write_batch.rs	`85.71% <85.71%> (ø)`
... and 5 more

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

delbonis

There's a lot of work that's being done to manipulate the state in places that aren't quite ideal for it, should find ways to improve this.

crates/evm-ee/src/execution.rs

crates/evm-ee/src/types.rs

CLONE_OPTIMIZATION_ANALYSIS.md

delbonis

Better, I have some organizational questions though.

crates/evm-ee/src/execution.rs

crates/evm-ee/src/utils.rs

crates/evm-ee/src/execution.rs

crates/evm-ee/src/utils.rs

.gitignore

crates/evm-ee/src/types/mod.rs

crates/evm-ee/src/types/partial_state.rs

crates/evm-ee/src/types/block.rs

crates/evm-ee/src/types/write_batch.rs

crates/evm-ee/src/execution.rs

crates/reth/evm/src/utils.rs

delbonis

not sure if that review comment is relevant right now or if we can defer it

make a note of it in any case

crates/evm-ee/src/execution.rs

Implement ExecutionEnvironment trait for EVM block execution using RSP's sparse state and Reth's execution engine. Core components: - EvmPartialState: Wraps EthereumState with witness data (bytecodes, ancestor_headers) - EvmWriteBatch: Wraps HashedPostState for state diffs - EvmBlock types: Header, Body, and complete Block with TransactionSigned - EvmExecutionEnvironment: Full ExecutionEnvironment trait implementation Trait methods: - execute_block_body: Execute block and compute state changes - complete_header: Combine intrinsics with computed commitments - verify_outputs_against_header: Validate state root and logs bloom - merge_write_into_state: Apply HashedPostState to EthereumState Refs: STR-1781

Add test_with_witness_params that validates full execution flow: - Loads real witness data from reference implementation - Tests execute_block_body with actual block data - Validates complete_header and verify_outputs_against_header Refs: STR-1781

Refs: STR-1781

cleanup

- Add utility functions (build_and_recover_block, accumulate_logs_bloom, etc.) - Update module structure to expose utils module

- Implement Codec for EvmHeader, EvmBlockBody, EvmBlock, EvmPartialState, EvmWriteBatch - Add encoding helpers (encode_rlp_with_length, encode_bytes_with_length) for consistency - Reorganize types into module with comprehensive test suite

…sion - Move EVM config creation to constructor for cleaner code structure - Extract witness database preparation into EvmPartialState for better encapsulation - Implement conversion logic for withdrawal intents to bridge messages

- Updated types - Updated codec impl to work with this change - refactored header chain validation logic - other minor nits

- ChainSpec: use Arc::clone instead of dereferencing (2x per block) - EthEvmConfig: pass by reference instead of cloning - Headers: use seal_ref_slow() to avoid cloning N+1 headers - BundleState/receipts/requests: take ownership instead of cloning (3x per block) - Block construction: remove redundant header clone

- Move accumulate_logs_bloom to alpen-reth-evm - Simplify compute_hashed_post_state - Refactor withdrawal intent message conversion - Use .clone() style instead of Arc::clone

- Move use statement to top of file in check_header_matches_body - Use impl_type_flat_struct macro for EvmBlock codec - Rename withdrawal_intents to extract_withdrawal_intents - Add panic documentation to extract_withdrawal_intents

- Serialize pre-computed hashes for headers and bytecodes to avoid rehashing inside zkVM - Add lazy hash caching in WitnessDB for addresses and storage keys - Implement custom DatabaseRef for WitnessDB with zero-copy references TODO: remove bincode serialization for EthereumState

Remove `complete_header` from `ExecutionEnvironment` and move to new `BlockAssembler` trait. Proof path only verifies blocks, doesn't build them. Block assembly still needed for test infrastructure. - Remove `complete_header` from `ExecutionEnvironment` trait - Add `BlockAssembler` trait for block assembly operations - Implement for EVM and Simple execution environments

- Validate deposits from BlockInputs against block withdrawals field - Add conversion helpers for SubjectId to Address and satoshis to gwei

…lementations - Remove bincode dependency, replace with rlp crate - Implement deterministic encoding for EthereumState using RLP and sorted iteration - Implement deterministic encoding for HashedPostState with sorted HashMap entries - Add custom codec functions in codec_shims module for external types

…n zkVM

delbonis · 2025-11-27T18:11:57Z

crates/evm-ee/src/execution.rs

+        // Encode withdrawal intent data: descriptor bytes + txid
+        let mut msg_data = Vec::new();
+        msg_data.extend_from_slice(&intent.destination.to_bytes());
+        msg_data.extend_from_slice(&intent.withdrawal_txid.0);
+
+        let bridge_gateway_account = AccountId::from(BRIDGE_GATEWAY_ACCOUNT);
+
+        // Create message to bridge gateway with withdrawal amount and intent data
+        let payload = MsgPayload::new(BitcoinAmount::from_sat(intent.amt), msg_data);


Use this message data to construct the message.

delbonis · 2025-11-27T18:13:21Z

crates/evm-ee/src/types/partial_state.rs

+    }
+}
+
+impl Codec for EvmPartialState {


Probably should have fuzzing/proptesting on this.

@delbonis I have created a ticket for it to unblock other tasks as proptesting it with EthereumState became a bit complicated.

purusang requested review from MdTeach and delbonis November 5, 2025 16:40

purusang force-pushed the STR-1781-impl-evm-ee branch 2 times, most recently from ce3a83a to 3d10b00 Compare November 5, 2025 16:48

delbonis requested changes Nov 5, 2025

View reviewed changes

purusang self-assigned this Nov 6, 2025

purusang requested review from delbonis and krsnapaudel November 6, 2025 05:39

delbonis reviewed Nov 12, 2025

View reviewed changes

CLONE_OPTIMIZATION_ANALYSIS.md Outdated Show resolved Hide resolved

purusang force-pushed the STR-1781-impl-evm-ee branch 2 times, most recently from 7ebeb7e to b492ad0 Compare November 12, 2025 15:22

delbonis requested changes Nov 12, 2025

View reviewed changes

purusang force-pushed the STR-1781-impl-evm-ee branch from b492ad0 to 55b55bc Compare November 13, 2025 15:11

purusang requested review from delbonis and storopoli November 13, 2025 16:23

purusang marked this pull request as ready for review November 13, 2025 16:23

purusang requested review from a team as code owners November 13, 2025 16:23

delbonis requested changes Nov 13, 2025

View reviewed changes

purusang force-pushed the STR-1781-impl-evm-ee branch from 5e812df to 7e80db7 Compare November 24, 2025 19:16

delbonis previously approved these changes Nov 25, 2025

View reviewed changes

crates/evm-ee/src/execution.rs Outdated Show resolved Hide resolved

purusang added 3 commits November 26, 2025 10:34

chore: add strata-evm-ee to workspace

d6ea890

Refs: STR-1781

purusang added 22 commits November 26, 2025 10:34

test: add --no-tests=warn flag to integration test command

600944c

fix(minor): fix import ordering in evm-ee execution tests & comment

02207b7

cleanup

refactor(evm-ee): extract helper utilities for code reuse

7fb3d4e

- Add utility functions (build_and_recover_block, accumulate_logs_bloom, etc.) - Update module structure to expose utils module

nits

b4f2d64

refactor: move header verification earlier

3077f81

refactor: update bytecodes & ancestors datatypes to BTreeMap

2120d87

- Updated types - Updated codec impl to work with this change - refactored header chain validation logic - other minor nits

refactor(evm-ee): split types module into separate files

b725aae

refactor(evm-ee): address PR review comments

e15daa7

- Move accumulate_logs_bloom to alpen-reth-evm - Simplify compute_hashed_post_state - Refactor withdrawal intent message conversion - Use .clone() style instead of Arc::clone

style: apply formatting to types module

8875f73

refactor: rename collect_withdrawal_intents to withdrawal_intents

1baa877

refactor: address PR review comments

0370541

- Move use statement to top of file in check_header_matches_body - Use impl_type_flat_struct macro for EvmBlock codec - Rename withdrawal_intents to extract_withdrawal_intents - Add panic documentation to extract_withdrawal_intents

refactor: move codec helpers to separate codec_shims module

0847440

nits

63a1500

refactor: rename collect_withdrawal function

f987de0

feat(evm-ee): implement deposit validation

615d433

- Validate deposits from BlockInputs against block withdrawals field - Add conversion helpers for SubjectId to Address and satoshis to gwei

chore: specify version for strata-codec

63c1178

purusang force-pushed the STR-1781-impl-evm-ee branch from 6bdd7b9 to 00a9395 Compare November 26, 2025 04:49

evm-ee: defer state root verification to merge to avoid state clone i…

fdf7d37

…n zkVM

purusang dismissed delbonis’s stale review via fdf7d37 November 26, 2025 17:44

purusang requested a review from delbonis November 26, 2025 18:13

delbonis requested changes Nov 27, 2025

View reviewed changes

sapinb mentioned this pull request Nov 28, 2025

ee block assembly #1169

Open

14 tasks

purusang added 2 commits December 1, 2025 16:24

refactor: use WithdrawalMsgData type for messages

9226823

nit: remove unused crate

d05b777

Str 1781 impl evm ee #1127

Are you sure you want to change the base?

Str 1781 impl evm ee #1127

Conversation

purusang commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Notes to Reviewers

Checklist

Related Issues

Uh oh!

github-actions bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

delbonis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

delbonis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

delbonis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

delbonis Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

delbonis Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

purusang Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

purusang commented Nov 5, 2025 •

edited

Loading

github-actions bot commented Nov 5, 2025 •

edited

Loading

codecov bot commented Nov 5, 2025 •

edited

Loading