Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 1, 2026

Automated update to Rust nightly by create-pull-request GitHub action

@github-actions github-actions bot requested a review from a team as a code owner February 1, 2026 17:40
@storopoli storopoli closed this Feb 1, 2026
@storopoli storopoli reopened this Feb 1, 2026
@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.62%. Comparing base (c61297f) to head (d4fe3cb).
⚠️ Report is 15 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1330      +/-   ##
==========================================
- Coverage   67.85%   63.62%   -4.23%     
==========================================
  Files         718      716       -2     
  Lines       66296    66208      -88     
==========================================
- Hits        44986    42128    -2858     
- Misses      21310    24080    +2770     
Flag Coverage Δ
functional ?
unit 63.62% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crates/ol/mempool/src/types.rs 91.61% <100.00%> (+0.66%) ⬆️

... and 107 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@storopoli storopoli requested review from a team as code owners February 1, 2026 22:25
bewakes
bewakes previously approved these changes Feb 2, 2026
@storopoli storopoli requested review from a team as code owners February 2, 2026 07:07
@storopoli storopoli force-pushed the create-pull-request/automated-nightly-update branch from 00424d2 to d4fe3cb Compare February 2, 2026 07:16
@storopoli
Copy link
Member

storopoli commented Feb 2, 2026

@prajwolrg @MdTeach rust-nightly broke succinct's sp1.

The --remap-path-scope flag was just stabilized in rust-lang/rust#147611. The new nightly-2026-02-01 toolchain includes this newly stabilized feature. Cargo now passes --remap-path-scope=object to rustc when using trim-paths (which SP1's build system uses via -Ztrim-paths (experimental)).

The SP1 v5.2.x toolchain doesn't recognize --remap-path-scope as a stable flag. When the host cargo (nightly-2026-02-01) invokes the SP1 bundled rustc, it passes the new stable flag which the older SP1 rustc doesn't understand.

Solutions

  1. Use SP1 v6.0.0-beta.1 - This has Rust 1.88.0 which supports the flag, this means updating zkaleido as well to use the same SP1 version.
  2. Wait for SP1 v6.0.0 stable - Should be coming soon

Solution 1 means keeping this PR alive.
Solution 2 means closing this PR.

I favor solution 2.

Also, we don't have a urge to update to 6.0.0-beta.1 (cc @MdTeach) since there are no security notices right now, right?

Opinions?

@prajwolrg
Copy link
Contributor

@prajwolrg @MdTeach rust-nightly broke succinct's sp1.

The --remap-path-scope flag was just stabilized in rust-lang/rust#147611. The new nightly-2026-02-01 toolchain includes this newly stabilized feature. Cargo now passes --remap-path-scope=object to rustc when using trim-paths (which SP1's build system uses via -Ztrim-paths (experimental)).

The SP1 v5.2.x toolchain doesn't recognize --remap-path-scope as a stable flag. When the host cargo (nightly-2026-02-01) invokes the SP1 bundled rustc, it passes the new stable flag which the older SP1 rustc doesn't understand.

Solutions

  1. Use SP1 v6.0.0-beta.1 - This has Rust 1.88.0 which supports the flag, this means updating zkaleido as well to use the same SP1 version.
  2. Wait for SP1 v6.0.0 stable - Should be coming soon

Solution 1 means keeping this PR alive. Solution 2 means closing this PR.

I favor solution 2.

Also, we don't have a urge to update to 6.0.0-beta.1 (cc @MdTeach) since there are no security notices right now, right?

Opinions?

I'm also in favor of waiting for SP1 v6.0.0

@storopoli
Copy link
Member

Ok closing this. In 2026-03-01 there will be a new automated nightly update PR and we can defer the SP1 SDK update decision to that upcoming PR.

@storopoli storopoli closed this Feb 9, 2026
@storopoli storopoli deleted the create-pull-request/automated-nightly-update branch February 9, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants