Fix footer links #3149
Open
Fix footer links #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These footer links have been broken since version 37.1.1 of govuk_publishing_components, which automatically converts all footer links to absolute URLs, using `Plek.new.website_root`: alphagov/govuk_publishing_components#3699 That corresponds to `https://www.gov.uk` on Production, but needs to be `https://content-publisher.publishing.service.gov.uk`. No other publishing app passes custom links to the footer like Content Publisher does, so this appears to be the only app affected. With that in mind, the simplest fix is to specify the correct absolute URL rather than deferring to the component (as opposed to, say, changing the value of `Plek.new.website_root`, which may have unintended side-effects). Tested in a Rails console on Production: ``` "#{Plek.external_url_for('content-publisher')}#{app.guidance_path}" => "https://content-publisher.publishing.service.gov.uk/documents/publishing-guidance" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These footer links have been broken since version 37.1.1 of govuk_publishing_components, which automatically converts all footer links to absolute URLs, using
Plek.new.website_root: alphagov/govuk_publishing_components#3699That corresponds to
https://www.gov.ukon Production, but needs to behttps://content-publisher.publishing.service.gov.uk.No other publishing app passes custom links to the footer like Content Publisher does, so this appears to be the only app affected. With that in mind, the simplest fix is to specify the correct absolute URL rather than deferring to the component (as opposed to, say, changing the value of
Plek.new.website_root, which may have unintended side-effects).Tested in a Rails console on Production:
Follow these steps if you are doing a Rails upgrade.