Fix, clean up & update database backups bucket TF. #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update to Terraform 1.0 syntax. - Use [standard module structure]. - Use current version of Terraform and providers. Module is now deployable from arm64. - Use current (non-deprecated) resources for configuring S3 buckets and replication. - Avoid unchecked templating; use aws_iam_policy_document resource so that IAM policies are at least somewhat validated at plan time and some common gotchas are no longer possible (like silently dropping duplicate JSON keys). - Remove disused IAM policies. - Enable access logging on the database-backups-replica bucket. - Add the [necessary permissions] over the source bucket to the replication role so that replication will still work once Object Lock is enabled. Already applied in all three environments (via TF 0.13). [necessary permissions]: https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lock-managing.html#object-lock-managing-replication [standard module structure]: https://developer.hashicorp.com/terraform/language/modules/develop/structure
samsimpson1
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already applied in all three environments (via TF 0.13).
This a prerequisite for enabling timelock, since our replication config needs to be in order before filing the ticket with Amazon to enable Object Lock on existing S3 buckets.
It's probably easier to read the new files than to read the diff.