Update + clean up Terraform for database backup S3 buckets. #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compliance mode = nobody can delete[1] until the time expires, not even root. Also set the no-public-access guardrails while we're at it. [1] Strictly speaking, it's at least theoretically possible to delete timelocked stuff by persuading Amazon to delete the entire account that contains the buckets, but that's probably not a very realistic attack scenario. (If somebody thinks it is, then we need to be multi-cloud already.)
The "db_admin" EC2 instances that used these have been gone a week or two now.
samsimpson1
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infra-database-backups-bucketmodule to reflect enabling timelock (in prod) and no-public-access guardrails.db_admininstances.descriptionon a module output.Tested: already applied/imported everywhere. (Terraform can't actually enable S3 Object Lock on existing buckets yet as the feature is only days old.)