Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for GOV.UK Prototype Kit v9.13.0 #1013

Merged
merged 2 commits into from
May 13, 2021
Merged

Conversation

EoinShaughnessy
Copy link
Contributor

This PR is to tell users:

@EoinShaughnessy EoinShaughnessy self-assigned this Apr 30, 2021
@EoinShaughnessy EoinShaughnessy linked an issue Apr 30, 2021 that may be closed by this pull request
3 tasks
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-prototype-kit-pr-1013 May 4, 2021 13:54 Inactive
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated
This was added in [Pull request #1012: Implement the new link and hover styles in the Prototype Kit](https://github.com/alphagov/govuk-prototype-kit/issues/1012).

### Update to GOV.UK Frontend
This was added in Pull request #???: Update to GOV.UK Frontend v3.12.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add link to pull request.

@EoinShaughnessy
Copy link
Contributor Author

@36degrees Thanks for reviewing! I've actioned your feedback (or tried to).

Just wondering about a few final bits before we send this content for pre-i. In particular:

  • Are the features listed in the right order? (I've done this by PR number, but what would users want to see first?)
  • How's the Sass feature description?
  • Is it weird to give the Frontend update its own heading? (As you say, previously, we've just bulleted such updates - but doing that here might look 'off,' because the other features have descriptions.)

@EoinShaughnessy EoinShaughnessy requested a review from 36degrees May 5, 2021 12:30
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@36degrees
Copy link
Contributor

Are the features listed in the right order? (I've done this by PR number, but what would users want to see first?)

Looks good to me 👍🏻

How's the Sass feature description?

Generally looks great, but I have a couple of suggestions for the first sentence just to make it slightly clearer.

Is it weird to give the Frontend update its own heading? (As you say, previously, we've just bulleted such updates - but doing that here might look 'off,' because the other features have descriptions.)

No, I think that works well 👍🏻

@EoinShaughnessy EoinShaughnessy requested a review from 36degrees May 7, 2021 12:30
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@EoinShaughnessy
Copy link
Contributor Author

Release notes have now passed pre-i, so I've sent them for 2i.

CHANGELOG.md Outdated Show resolved Hide resolved
@EoinShaughnessy
Copy link
Contributor Author

EoinShaughnessy commented May 12, 2021

@36degrees Before we move the linked issue to Ready to Release/Done, do we need to add a link to the (as-yet-uncreated) PR for the Frontend release?

@36degrees
Copy link
Contributor

We won't know what the PR is until we've released GOV.UK Frontend, so we'll have to make that change before we merge this. Other than adding that, is this ready to go?

@EoinShaughnessy
Copy link
Contributor Author

@36degrees Yeah, it's ready to go.

@36degrees 36degrees merged commit 01af5c7 into main May 13, 2021
@36degrees 36degrees deleted the pk-rel-notes branch May 13, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write release notes for Prototype Kit v9.13.0
3 participants