-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dos and added JWT version range 7-10 #173
base: main
Are you sure you want to change the base?
Conversation
8b5204f
to
b66c618
Compare
just validating this with jwt==10 as that's failing at the moment 🤔 |
jwt10 is deprecated so shouldn't be used 10.0.2 is fine |
Not sure if maybe my attempt at testing this is wrong? I have manually edited
Any thoughts? When I read that it seems to say to me that it wants to use NewtonSoft.Json == 10.0.3 rather than 13.0.2 but I'm not sure why. |
The support for package ranges is a bit odd. for testing i had to select the ones i wanted to test against from nuget manager. Then build that version. if you aren't using VS set the versions in the project file first |
Are you able to confirm that the client will install for users on JWT==10.0.2? As I don't use .net/VS, my process is:
I don't feel confident merging this at the moment as I'm not sure that the client can work with v10.0.2 of JWT? |
Just wondering how you are getting on? |
I have run the unit tests and the local ones all pass. I need the following test information to run the other tests against the live api. NOTIFY_API_URL Regards kieron |
Internal copy of #171
What problem does the pull request solve?
Checklist
DOCUMENATION.md
andCHANGELOG.md
)src/GovukNotify/GovukNotify.csproj
)