-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Package support and removal of vulnerable Newtonsoft packages #186
base: main
Are you sure you want to change the base?
Conversation
merged in root changes, excluded vulnerable Newtonsoft versions updated NUnit and updated tests to map to the new namespace NUnit.Framework.Assert is now NUnit.Framework.Legasy.ClassicAssert
<PackageReference Include="NUnit3TestAdapter" Version="3.9.0" /> | ||
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" /> | ||
<PackageReference Include="Moq" Version="4.20.70" /> | ||
<PackageReference Include="MSTest.TestAdapter" Version="3.2.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the MSTest packages can be removed since the project uses NUnit tests instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These have now been removed.
I have also added a Framework 4.8 compiled Dll
Updated NUnit version
# Conflicts: # src/GovukNotify.Tests/IntegrationTests/Assertions.cs # src/GovukNotify.Tests/IntegrationTests/NotificationClientAsyncIntegrationTests.cs # src/GovukNotify.Tests/IntegrationTests/NotificationClientIntegrationTests.cs # src/GovukNotify.Tests/UnitTests/NotificationClientAsyncUnitTests.cs # src/GovukNotify.Tests/UnitTests/NotificationClientUnitTests.cs # src/GovukNotify/GovukNotify.csproj
Bumped version Updated package references
I have added the latest updates ready for merging |
What problem does the pull request solve?
It allows support of new Newtonsoft and JWT packages. It drops support of vulnerable Newtonsoft packages
Updated Unit tests so they support the new version of NUnit
Added .NETFramework 4.8
Updated test packages and tests
Merged in current origin/main
Checklist
CHANGELOG.md
src/GovukNotify/GovukNotify.csproj
)