New Package support and removal of vulnerable Newtonsoft packages #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
June 7, 2023 14:22
merged in root changes, excluded vulnerable Newtonsoft versions updated NUnit and updated tests to map to the new namespace NUnit.Framework.Assert is now NUnit.Framework.Legasy.ClassicAssert
| <PackageReference Include="NUnit3TestAdapter" Version="3.9.0" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" /> | ||
| <PackageReference Include="Moq" Version="4.20.70" /> | ||
| <PackageReference Include="MSTest.TestAdapter" Version="3.2.0" /> |
There was a problem hiding this comment.
I think the MSTest packages can be removed since the project uses NUnit tests instead
There was a problem hiding this comment.
These have now been removed.
I have also added a Framework 4.8 compiled Dll
added 5 commits
April 24, 2024 10:07
Updated NUnit version
# Conflicts: # src/GovukNotify.Tests/IntegrationTests/Assertions.cs # src/GovukNotify.Tests/IntegrationTests/NotificationClientAsyncIntegrationTests.cs # src/GovukNotify.Tests/IntegrationTests/NotificationClientIntegrationTests.cs # src/GovukNotify.Tests/UnitTests/NotificationClientAsyncUnitTests.cs # src/GovukNotify.Tests/UnitTests/NotificationClientUnitTests.cs # src/GovukNotify/GovukNotify.csproj
Bumped version Updated package references
|
I have added the latest updates ready for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does the pull request solve?
It allows support of new Newtonsoft and JWT packages. It drops support of vulnerable Newtonsoft packages
Updated Unit tests so they support the new version of NUnit
Added .NETFramework 4.8
Updated test packages and tests
Merged in current origin/main
Checklist
CHANGELOG.mdsrc/GovukNotify/GovukNotify.csproj)