Skip to content

PP-11787: Minor docs changes based on feedback #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

NathanD-GDS
Copy link
Contributor

Context

We’ve identified a need for a few small documentation changes through reviews and support tickets. These changes are not large enough to need a whole ticket to themselves, so they’re aggregated into this one.

The changes

  • Corporate card fee page - remove inverted commas from response attribute names
  • Use your own payment failure pages - link for payment status goes to the wrong page at the moment
  • Use Welsh - link text currently implies that we have specific instructions for Welsh pages when the link should only go to the generic create payment docs page
  • Testing integration - clarify the testing actions for recurring card payment cards
  • Scheduled downtime - fix time formatting from 4am to 4:00am
  • Go live with Stripe - make it clear that services need a real, physical address, and not a PO box
  • Delayed capture - mention that it cannot be used with recurring payments
  • Digital wallets - clarify that wallets respect any disabled card brands

@NathanD-GDS NathanD-GDS changed the title PP-11787Minor docs changes based on feedback PP-11787: Minor docs changes based on feedback Nov 3, 2023
Copy link
Contributor

@SandorArpa SandorArpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NathanD-GDS NathanD-GDS merged commit 4ac89ef into master Nov 6, 2023
@NathanD-GDS NathanD-GDS deleted the PP11787minorUpdates branch November 6, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants