Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11862: Adds more digital wallet references #947

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Conversation

NathanD-GDS
Copy link
Contributor

Context

Apple Pay is now enabled by default for all services, regardless of PSP. Because of this, we should acknowledge the differences between standard payments and digital wallet payments in other places in the docs.

Changes proposed in this pull request

This PR changes the:

  • 'Take digital wallet payments' to:
    • reflect that Apple Pay is now on by default
  • 'Add corporate card fees' page to make it clear that corporate fees cannot apply to digital wallet payments
  • 'Report and reconcile your payments' to make sure users know digital wallets can affect reconciliation
  • 'How GOV.UK Pay works' page by:
    • mentioning that users can pay by digital wallet payments
    • updating the screenshot of 'Enter payment details' page to show updated UI, content, and Apple Pay option
    • descriptions of card_details in the API reference to mention the potential unreliability of cardholder details with digital wallets

Copy link

@elenaschwan elenaschwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me. One comment on 'from' vs 'on' - see what you think.

Copy link
Contributor

@alexbishop1 alexbishop1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes but I’m not sure about the term “accurate”.

@NathanD-GDS
Copy link
Contributor Author

@alexbishop1 Pushed the updates - could you re-review?

@NathanD-GDS NathanD-GDS merged commit 88a588d into master Jan 23, 2024
2 checks passed
@NathanD-GDS NathanD-GDS deleted the applePayEnabled branch January 23, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants