Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-12126: Minor docs updates (January/February 2024) #948

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

NathanD-GDS
Copy link
Contributor

Context

Through docs reviews, support requests, and developer engagement, we’ve identified a number of small issues with our documentation. Each of these issues is not enough to merit its own Jira ticket, so they’re consolidated in this one.

Changes proposed in this pull request

  • clarify where and when provider_id appears in API responses
  • remove ‘conduct’ from ‘Integrate with the GOV.UK Pay API’ for simplicity
  • change Enter card details to Enter payment details to reflect new name of that page in the user journey

Copy link

@ImogenCraigmile ImogenCraigmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple of comments which are more just my thoughts and could be personal preference but in general the changes look really good and definitely work with our style guide!

@NathanD-GDS NathanD-GDS merged commit 7c63c99 into master Jan 31, 2024
2 checks passed
@NathanD-GDS NathanD-GDS deleted the minorDocsUpdatesFeb24 branch January 31, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants