Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html.md.erb #949

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Conversation

Jonathan-Scott14
Copy link
Contributor

Scheduled review, minor updates to wording, including PCI 4.0. Updated SAQ link to 4.0 version and clarified TLS versions for HTTPS section.

Context

Changes proposed in this pull request

Guidance to review

Scheduled review, minor updates to wording, including PCI 4.0. Updated SAQ link to 4.0 version and clarified TLS versions for HTTPS section.
Copy link
Contributor

@NathanD-GDS NathanD-GDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions to make sure we're consistent on this page and keeping it as simple and style guide-compliant as possible!

source/security/index.html.md.erb Outdated Show resolved Hide resolved
source/security/index.html.md.erb Outdated Show resolved Hide resolved
source/security/index.html.md.erb Outdated Show resolved Hide resolved
source/security/index.html.md.erb Outdated Show resolved Hide resolved
@Jonathan-Scott14
Copy link
Contributor Author

Have accepted changes Nathan suggested. The audit is a Qualified Security Assessor (QSA) from BSI, which we could add?

@NathanD-GDS
Copy link
Contributor

Have accepted changes Nathan suggested. The audit is a Qualified Security Assessor (QSA) from BSI, which we could add?

@Jonathan-Scott14 I've made a small change to add this now. If you're happy to commit it, I'm happy to approve the PR.

Copy link
Contributor

@NathanD-GDS NathanD-GDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Jonathan-Scott14 Jonathan-Scott14 merged commit 6858f1f into master Feb 5, 2024
2 checks passed
@Jonathan-Scott14 Jonathan-Scott14 deleted the Jonathan-Scott14-patch-1 branch February 5, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants