Fix: (org-ql-view.el) Adjust priority for agenda elements #325
Conversation
|
Thanks for submitting this. I'll plan to merge it for v0.8. |
alphapapa
force-pushed
the
master
branch
2 times, most recently
from
059b10c
to
77b4c2b
Compare
|
@anpandey: I made a pull request into your repository that fixes the merge conflict. Merging it there should make the patch ready to merge here too. |
|
Update: seems like even after syncing the branch with the upstream here,
this patch no longer works (the entities are not sorted correctly).
larrasket ***@***.***> writes:
… @anpandey: I made a pull request into your repository that fixes the merge conflict. Merging it there
should make the patch ready to merge here too.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
--
Regards,
Salih
|
Be sure you test in a clean Emacs configuration, e.g. using https://github.com/alphapapa/makem.sh (load up |
|
It didn't work either when I tried that time. I tried now, after
upgrading org version [now: Org mode version 9.6.17 (9.6.17-??-25c786f]
it worked both in the sandbox and with my main configuration.
|
Ok, so it does work now, with the latest, rebased patch and the latest Org version? |
|
Adam Porter ***@***.***> writes:
Ok, so it does work now, with the latest, rebased patch and the latest Org version?
Yes, I can confirm.
…--
Regards,
Salih
|
|
@anpandey By the way, we're hoping to merge org-ql into Org mode, which means that FSF copyright assignment comes into play. AFAICT this patch plus your other one that was committed (i.e. not including comments) would be 12 lines, which is allowable without doing assignment. But it would be good to do the CA anyway. Have you done this already for Emacs/Org, or would you be willing to? |
|
@alphapapa That's great news! I have not signed any CA before, but I can confirm my employer will allow it (as long as the assignment is to the FSF). |
Great. You can send an email to [email protected] or to [email protected] to request the assignment form. Please let me know when you've submitted it and when you receive the confirmation (it usually takes a few weeks, depending on circumstances). |
|
@alphapapa I've received the confirmation of the copyright assignment to the FSF. |
Thanks. I recently found out from Eli Zaretskii that I'm supposed to get confirmation of this directly from either the FSF clerk or an Emacs maintainer before accepting contributions. Would you be willing to ask the clerk to email confirmation to me directly? |
|
No problem, I've asked the copyright clerk to email you the confirmation at the address on your profile. |
|
Thanks. |
|
@alphapapa You should have gotten a confirmation email from the FSF copyright clerk. |
@anpandey I'm not sure if I did. Anyway, Eli told me further that what I'm supposed to do is ask him or one of the other Emacs maintainers to verify that your name and email address are on their list. Would you please let me know exactly what name and address to ask him about? Thanks. |
|
Sure, the name should be 'Ankit Raj Pandey', and the email '[email protected]'. |
|
@alphapapa any updates on merging that to master? |
|
My time to work on Emacs packages is limited lately. I might be able to merge this this weekend. |
Fixes #38.