-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Add ignore strategies #109
Conversation
I wonder if the "production mode" is useful. At the end of the day, the devtools don't load unless you inspect the page. Since we're client-side, switching a global variable before opening devtools seems easy enough (so if some did have production mode on, you can switch off trivially) About the I still think adding a way to hide the components from the panel is going to give the best outcome in terms of ease of use, education/discoverability and implementation. We could even persist which components are hidden across refreshes/reloads using https://developer.chrome.com/extensions/storage (which we already request permission for) |
We could also do both and just not document it. Anyone curious enough would probably end up here via a Google search. I'm ok if we don't though. maybe let's see if anyone ends up here and comments on it. I can open a discussion post this week about it. One advantage of disabling it all together though is it doesn't initialize anything. Or does Chrome wait until the tab has focus? I do think we should add the filtering regardless. It's a big project though I think. |
Backend.js doesn't get injected until the devtools are opened so no init unless you've got devtools open. I think we can have a default filter on You can see what I'm thinking of in #111, for now we can have some text about being able to ignore components using |
🤔 the above answer about how the extension works probably should go into a contributing.md |
Would resolve #90
Just a concept for how we could handle not showing some components, or not loading at all.
Since you don't necessarily bundle Alpine, or the functions Alpine uses, identifying production mode doesn't seem possible.
We could just leave it up to the user to manage visibility.