ALCF Update #28
Merged
ALCF Update #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k_globus_transfer.py. Also patched orchestration/globus/transfer.py to coerce transfer data into strings.
dylanmcreynolds
requested changes
Sep 20, 2024
orchestration/globus/transfer.py
Outdated
| @@ -115,7 +115,7 @@ def start_transfer( | |||
| relative_path = item.relative_to(source_path.parent) | |||
| tdata.add_item(str(item), os.path.join(dest_path, str(relative_path))) | |||
| else: | |||
| tdata.add_item(source_path, dest_path) | |||
| tdata.add_item(str(source_path), str(dest_path)) | |||
There was a problem hiding this comment.
If the issue is that the variables are pathlin.Path instances, then can we also change the type hints for the variables in the function call?
There was a problem hiding this comment.
oh wait...
the typing is correct on the function definition, it's that we reinitizlize source_path.
dest_path probably comes in as a str and doesn't need to be coerced
…rce_path) since it is reinitialized into a Path object
…rce_path) since it is reinitialized into a Path object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed argparse to typer in scripts/check_globus_compute.py and check_globus_transfer.py. Also patched orchestration/globus/transfer.py to coerce transfer data into strings.