Also search for ucm2/conf.d/[${CardDriver}|${KernelDriver}]/${CardName}.conf#374
Also search for ucm2/conf.d/[${CardDriver}|${KernelDriver}]/${CardName}.conf#374Daniel-Abrecht wants to merge 1 commit intoalsa-project:masterfrom
Conversation
…e}.conf The CardLongName may be derived from various DMI properties of the system, that have little to do with the card itself. Sometimes, that may be a good thing, but sometimes, it may contain the completely generic "Unknown-UnknownProduct-", see https://gitlab.com/postmarketOS/pmaports/-/issues/1498#note_1716959721 for example. At least for devices using device tree and simple-card, the name of the card (CardName), which then comes from the device tree, which can be provided by the kernel too, may be a lot more relevant, and does actually identify the device. Signed-off-by: Daniel Abrecht <public@danielabrecht.ch>
|
Why the simple-card driver does not set the CardLongName (GUI string) from DT, too? The DMI fallback for card's long name is there just for ASoC laziness. EDIT: Also, UCM has other way to fetch the DMI info ( |
|
I don't think the simple-card driver can set the CardLongName from the DT right now. It would have to set Shall I send a patch for that? |
|
If you look to conf.d/simple-card there is Another option is to create |
|
I think So, the circumstances in which this works are probably going to be about the same as for the pinephone-pro. For distros where the kernel is loaded directly by uboot without EFI, there will be no DMI, and the It seams there is also a blacklist of invalid DMI names in the kernel, I'll add I will also look into doing the matching in |
90b4ed1 to
67998e1
Compare
The CardLongName may be derived from various DMI properties of the system, that have little to do with the card itself. Sometimes, that may be a good thing, but sometimes, it may contain the completely generic "Unknown-UnknownProduct-", see https://gitlab.com/postmarketOS/pmaports/-/issues/1498#note_1716959721 for example. At least for devices using device tree and simple-card, the name of the card (CardName), which then comes from the device tree, which can be provided by the kernel too, may be a lot more relevant, and does actually identify the device.