Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt 6 support #255

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Qt 6 support #255

wants to merge 10 commits into from

Conversation

altendky
Copy link
Owner

@altendky altendky commented Jul 12, 2021

Stalled on:

Draft for:

  • Update PySide6 requirements for above fix.

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #255 (5f5070e) into main (966531f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #255   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         2023      2032    +9     
  Branches       138       138           
=========================================
+ Hits          2023      2032    +9     
Impacted Files Coverage Δ
qtrio/_tests/helpers.py 100.00% <ø> (ø)
qtrio/examples/readme/qt.py 100.00% <ø> (ø)
qtrio/examples/readme/qtrio_example.py 100.00% <ø> (ø)
qtrio/_core.py 100.00% <100.00%> (ø)
qtrio/_qt.py 100.00% <100.00%> (ø)
qtrio/_tests/examples/readme/test_qt.py 100.00% <100.00%> (ø)
qtrio/_tests/examples/test_crossingpaths.py 100.00% <100.00%> (ø)
qtrio/_tests/test_core.py 100.00% <100.00%> (ø)
qtrio/_tests/test_dialogs.py 100.00% <100.00%> (ø)
qtrio/_tests/test_qt.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966531f...5f5070e. Read the comment docs.

@altendky
Copy link
Owner Author

SignalInstance equality checks broken in PySide 5.15.2+ including 6.
https://bugreports.qt.io/browse/PYSIDE-1431

@altendky altendky added the stalled Waiting on external action label Jul 21, 2021
@xaberus
Copy link

xaberus commented Sep 29, 2023

Hi, what is the current status for this? The tests from the qt6 branch seem to pass on pyside6-6.5.2, but I have not taken a close look at the bug report mentioned up top. Is there a dedicated test that checks for signal equality? Or is there another reason why this PR is stalled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalled Waiting on external action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants