Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jitpack import issue for UsbSerial dependency #119

Closed
wants to merge 2 commits into from

Conversation

hwh97
Copy link

@hwh97 hwh97 commented Oct 28, 2024

As a temporary workaround, I used import the latest successful build hash tag (7ad6c9f6) to fix the Jitpack import issue for the UsbSerial dependency.

Related issue: #118

Copy link
Contributor

@ChaseGuru ChaseGuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is worth merging. It should be a fact that anyone who doesn't have the prior working jitpack version of the dependency cached the plugin will not work as is and this change fixes that.

THOUGH, I probably prefer using this guy's fork:
felHR85/UsbSerial#375 (comment)

Since it seems to modernize a few things.

@berdroid
Copy link
Contributor

Using the fix from this PR ea4eb8b results in an error for me:

"Artifact name must not be null!"

Adding

name = UsbSerial

to the artifact seems to fix that.

See also felHR85/UsbSerial#375 (comment)

@hwh97
Copy link
Author

hwh97 commented Nov 19, 2024

Using the fix from this PR ea4eb8b results in an error for me:

Weird, it works on my side, maybe it's a compatibility issue from Gradle.

But as @ChaseGuru said, it's better to use a fixed version. The cache build we use may be cleared at any time. I'm closing this PR and hope this issue can fixed soon. Thanks.

@hwh97 hwh97 closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants