Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probe version of scrolloverflow.js #2875

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

nnmrts
Copy link

@nnmrts nnmrts commented Aug 31, 2017

This file is a merge of the customized scrolloverflow.js and iscroll-probe.js to also allow the precise "scroll" event from iScroll. More info: http://iscrolljs.com/#custom-events

@nnmrts
Copy link
Author

nnmrts commented Aug 31, 2017

Oh, sorry, I think I used the master version of your scrolloverflow.js to make this new file. Arghh. 🤕

@alvarotrigo
Copy link
Owner

This file is a merge of the customized scrolloverflow.js and iscroll-probe.js

What do you mean by that?
Did you fix the issues in iScroll Probe as I did on the customized iScroll ? Could you provide more details about it ?

@nnmrts
Copy link
Author

nnmrts commented Oct 7, 2017

For me the event scroll wasn't available in Fullpage.js. That's a feature only available in the iScroll scroll-probe.js edition and as far as I know, you used the normal edition to create your customized iScroll edition. So I first took your customized scrolloverflow.js and added the probe feature from the scroll-probe.js file. I don't know what you mean with:

Did you fix the issues in iScroll Probe as I did on the customized iScroll?

I mean, I didn't change your customized iScroll file itself, so your fixes are still there.

@alvarotrigo
Copy link
Owner

That's a feature only available in the iScroll scroll-probe.js edition and as far as I know, you used the normal edition to create your customized iScroll edition.

The iScroll version used in fullPage.js is a customization of the iScroll official version. There were some bugs in the official version that were preventing it to work as expected, and as far as I know they never got solved because the project is kind of inactive.
I guess you didn't apply those changes?

I mean, I didn't change your customized iScroll file itself, so your fixes are still there.

Yeah, I get that, although I would prefer to only have a single scrolloverflow.js file instead of two.
Makes things easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants