Add a :preservenothing option to never persist build files #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to not leave files behind"
RootTJNII
force-pushed
the
TJNII-PreserveNothing
branch
from
0c73068 to
66bee00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
:preservenothingflag. When set no build files will be persisted. This is important for our use case as we're using this gem to generate sensitive documents, so having the .tex files laying around after they're needed is a security concern, as well as being generally useful in environments where these files will never be read in any case.The main change is the work is now done in a Ruby
Dir.mktempdirblock that is always cleaned up. If:preservenothingis falsy then thebasediris created and input.tex and input.log are copied to it to maintain existing behavior. If:preservenothingis falsy and:preserveworkis truthy then the tmpdir is copied to workdir to maintain existing behavior. If:preservenothingis truthy then nothing is copied out of the tempdir which is automatically cleaned up by Ruby.The exception message changes when
:preservenothingis truthy as there are no log files to check. When:preservenothingis falsy a conscious effort was made to keep the gem behavior unchanged.