Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RFC 57: Single-Field Register Definition and Usage Shortcut #79

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Implement RFC 57: Single-Field Register Definition and Usage Shortcut #79

merged 3 commits into from
Mar 18, 2024

Conversation

tpwrules
Copy link
Contributor

Tested on my design and it works nice.

@tpwrules tpwrules requested a review from jfng as a code owner March 16, 2024 03:45
@tpwrules tpwrules mentioned this pull request Mar 16, 2024
Closed
jfng
jfng reviewed Mar 18, 2024
View reviewed changes
amaranth_soc/csr/reg.py Outdated Show resolved Hide resolved
jfng
jfng requested changes Mar 18, 2024
View reviewed changes
Copy link
Member

@jfng jfng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides one nitpick.

@tpwrules
Copy link
Contributor Author

Seems reasonable, fixed.

@jfng jfng added this pull request to the merge queue Mar 18, 2024
@jfng
Copy link
Member

jfng commented Mar 18, 2024

Thank you!

Merged via the queue into amaranth-lang:main with commit 9b90d72 Mar 18, 2024
12 checks passed
@tpwrules tpwrules deleted the implement-rfc-57 branch March 18, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfng jfng jfng approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tpwrules @jfng