Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-cwa-ciwindows by merging new changes from aws-cwa-dev #155

Conversation

KlwntSingh
Copy link

Description:
Updated aws-cwa-ciwindows by merging aws-cwa-dev using git merge aws-cwa-dev.

Conflicts

Resolved conflict in kubeletclient.go

movence and others added 4 commits December 20, 2023 09:55
…rics (amazon-contributing#144)

* Return error for enhanced container insights for missing metrics in emfexporter

* move import

* Add debug line and make error message more descriptive

* Fix import again

* Run make gotidy

* Revert "Run make gotidy"

This reverts commit 5b9ce4d.

* Update exporter/awsemfexporter/metric_translator_test.go

Co-authored-by: Jeffrey Chien <chienjef@amazon.com>

---------

Co-authored-by: Jeffrey Chien <chienjef@amazon.com>
@KlwntSingh KlwntSingh requested a review from mxiamxia as a code owner January 30, 2024 22:29
@KlwntSingh KlwntSingh changed the base branch from main to aws-cwa-ciwindows January 30, 2024 22:29
@KlwntSingh KlwntSingh changed the title Merge aws-cwa-dev into aws-cwa-ciwindows Update aws-cwa-ciwindows by merging new changes from aws-cwa-dev Jan 30, 2024
@KlwntSingh
Copy link
Author

Merging is squashing the commits, This will lead to merge conflicts when Raising PR from this dev branch again aws-cwa-dev branch

@KlwntSingh KlwntSingh closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants