Merged
Conversation
This is best practice for Rust and recommended for all projects. See: - rust-lang/cargo#12382 - https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
13 tasks
Member
|
Oh, nice! I didn't see that. Just fix the quality check |
Contributor
Author
|
My bad for missing it. The quality check was introduced in rust I would recommend specifying the rust toolchain version used either in the README or via a toolchain file, or even both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is best practice for Rust and recommended for all projects.
See:
Furthermore, this will help the project to be built reliably within nixpkgs. Amber-lsp is being added in this PR