fix: remove incorrect dbasunag/opendatahub-tests submission#321
Merged
kami619 merged 1 commit intoambient-code:mainfrom Feb 23, 2026
Conversation
PR ambient-code#301 submitted an assessment for dbasunag's fork instead of the official opendatahub-io/opendatahub-tests repository. The correct submission was made in PR ambient-code#314. This removes the incorrect submission to avoid duplicate/confusing entries in the leaderboard. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
📈 Test Coverage Report
Coverage calculated from unit tests only |
15 tasks
Contributor
|
🎉 This PR is included in version 2.29.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Remove Incorrect Fork Submission from Leaderboard
Description
This PR removes an incorrect leaderboard submission where a user's fork was submitted instead of the intended upstream repository.
Background: PR #301 submitted
dbasunag/opendatahub-tests(a personal fork) to the leaderboard when the user intended to submit the upstream repositoryopendatahub-io/opendatahub-tests. The correct submission was subsequently made in PR #314.This cleanup fix removes the incorrect submission file. The leaderboard data will be automatically regenerated by GitHub Actions when this PR is merged.
Type of Change
Related Issues
Fixes #TBD (create issue first)
Related PRs:
Root Cause
The
agentreadytool currently lacks fork detection. When users runagentready assesson a local clone of a forked repository, the tool extracts the repository URL fromgit config remote.origin.url, which points to the fork. Thesubmitcommand then submits this fork URL to the leaderboard without detecting that it's a fork or prompting the user to confirm.Code locations:
src/agentready/services/scanner.py:188-192- Extracts URL from git remotesrc/agentready/cli/submit.py:50-93, 177-213- Submits without fork detectionDetailed analysis: See
artifacts/bugfix/analysis/root-cause.mdChanges Made
submissions/dbasunag/opendatahub-tests/2026-02-18T19-35-35-assessment.json(926 lines)docs/_data/leaderboard.json) will be automatically updated via GitHub Actions workflowFiles changed: 1 file, 926 deletions
Commit:
bdd1d47- "fix: remove incorrect dbasunag/opendatahub-tests submission"How Leaderboard Update Works
submissions/**/*-assessment.json.github/workflows/leaderboard.yml(update job, lines 186-214)scripts/generate-leaderboard-data.pyrebuilds leaderboard from all submission filesdocs/_data/leaderboard.jsonis regenerated without the incorrect entryExpected timeline: 5-10 minutes from merge to live update
Testing
Pre-merge Verification
generate-leaderboard-data.py- scans directory and rebuilds from scratchPost-merge Verification Required
docs/_data/leaderboard.jsonno longer containsdbasunag/opendatahub-testsAutomated Tests
Note: This is a data cleanup fix with no code changes, so traditional unit/integration tests don't apply. The verification is operational:
pytest) - N/A (no code changes)Checklist
Before/After Comparison
Before (Current State)
After (Expected State)
Screenshots
Not applicable (leaderboard data change, no UI changes in this PR)
Additional Notes
Why This Fix is Safe
Why This Won't Break Anything
Follow-Up Work Needed
This fix addresses the symptom, not the root cause. To prevent recurrence:
submitcommandEstimated effort: 4-6 hours for preventative fix + tests
Priority: Medium (improves UX, prevents duplicate entries)