Skip to content

fix: remove incorrect dbasunag/opendatahub-tests submission#321

Merged
kami619 merged 1 commit intoambient-code:mainfrom
kami619:fix/remove-incorrect-dbasunag-opendatahub-tests-submission
Feb 23, 2026
Merged

fix: remove incorrect dbasunag/opendatahub-tests submission#321
kami619 merged 1 commit intoambient-code:mainfrom
kami619:fix/remove-incorrect-dbasunag-opendatahub-tests-submission

Conversation

@kami619
Copy link
Collaborator

@kami619 kami619 commented Feb 23, 2026

Pull Request: Remove Incorrect Fork Submission from Leaderboard

Description

This PR removes an incorrect leaderboard submission where a user's fork was submitted instead of the intended upstream repository.

Background: PR #301 submitted dbasunag/opendatahub-tests (a personal fork) to the leaderboard when the user intended to submit the upstream repository opendatahub-io/opendatahub-tests. The correct submission was subsequently made in PR #314.

This cleanup fix removes the incorrect submission file. The leaderboard data will be automatically regenerated by GitHub Actions when this PR is merged.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test coverage improvement

Related Issues

Fixes #TBD (create issue first)

Related PRs:

Root Cause

The agentready tool currently lacks fork detection. When users run agentready assess on a local clone of a forked repository, the tool extracts the repository URL from git config remote.origin.url, which points to the fork. The submit command then submits this fork URL to the leaderboard without detecting that it's a fork or prompting the user to confirm.

Code locations:

  • src/agentready/services/scanner.py:188-192 - Extracts URL from git remote
  • src/agentready/cli/submit.py:50-93, 177-213 - Submits without fork detection

Detailed analysis: See artifacts/bugfix/analysis/root-cause.md

Changes Made

  • Deleted submissions/dbasunag/opendatahub-tests/2026-02-18T19-35-35-assessment.json (926 lines)
  • Leaderboard data (docs/_data/leaderboard.json) will be automatically updated via GitHub Actions workflow

Files changed: 1 file, 926 deletions

Commit: bdd1d47 - "fix: remove incorrect dbasunag/opendatahub-tests submission"

How Leaderboard Update Works

  1. Trigger: GitHub Actions workflow detects path change in submissions/**/*-assessment.json
  2. Workflow: .github/workflows/leaderboard.yml (update job, lines 186-214)
  3. Script: scripts/generate-leaderboard-data.py rebuilds leaderboard from all submission files
  4. Result: docs/_data/leaderboard.json is regenerated without the incorrect entry
  5. Deploy: GitHub Pages automatically deploys updated leaderboard

Expected timeline: 5-10 minutes from merge to live update

Testing

Pre-merge Verification

  • Verified submission file deleted in commit
  • Confirmed GitHub Actions workflow triggers on file deletions (path filter includes deletions)
  • Reviewed generate-leaderboard-data.py - scans directory and rebuilds from scratch
  • Checked no other mismatched submissions exist (verified via script)

Post-merge Verification Required

  • Monitor GitHub Actions workflow execution (should auto-run on merge)
  • Verify docs/_data/leaderboard.json no longer contains dbasunag/opendatahub-tests
  • Check live leaderboard: https://agentready.dev/leaderboard/
  • Confirm entry count decreases from 11 to 10 repositories

Automated Tests

Note: This is a data cleanup fix with no code changes, so traditional unit/integration tests don't apply. The verification is operational:

  • Unit tests pass (pytest) - N/A (no code changes)
  • Integration tests pass - N/A (no code changes)
  • Manual testing performed (verified script behavior)
  • No new warnings or errors

Checklist

  • My code follows the project's code style (N/A - file deletion only)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (N/A - no new code)
  • I have made corresponding changes to the documentation (see artifacts/bugfix/docs/)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective (N/A - cleanup fix, no preventative tests yet)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Before/After Comparison

Before (Current State)

$ ls submissions/dbasunag/opendatahub-tests/
2026-02-18T19-35-35-assessment.json

$ jq '.overall[] | select(.org == "dbasunag")' docs/_data/leaderboard.json
{
  "repo": "dbasunag/opendatahub-tests",
  "org": "dbasunag",
  "score": 69.9,
  "tier": "Silver",
  ...
}

After (Expected State)

$ ls submissions/dbasunag/opendatahub-tests/
ls: submissions/dbasunag/opendatahub-tests/: No such file or directory

$ jq '.overall[] | select(.org == "dbasunag")' docs/_data/leaderboard.json
# (no results)

$ jq '.total_repositories' docs/_data/leaderboard.json
10  # decreased from 11

Screenshots

Not applicable (leaderboard data change, no UI changes in this PR)

Additional Notes

Why This Fix is Safe

  1. File deletion only: No code changes, minimal risk
  2. Idempotent script: Leaderboard generation script scans directory and rebuilds—safe to re-run
  3. Automatic rollback: If needed, reverting this commit will restore the file
  4. Tested workflow: Leaderboard update workflow has been running since Dec 2025 (PR feat: Community Leaderboard for AgentReady Scores #146)

Why This Won't Break Anything

  • The deleted submission is completely independent (no foreign keys, no dependencies)
  • The leaderboard generation script handles missing files gracefully
  • GitHub Actions workflow is proven stable (regenerates on every submission merge)
  • No user-facing API changes or behavior changes

Follow-Up Work Needed

This fix addresses the symptom, not the root cause. To prevent recurrence:

  1. Create enhancement issue for fork detection in submit command
  2. Implement fork detection: Prompt user when submitting a fork
  3. Add tests: Unit tests for fork detection, integration tests for leaderboard generation

Estimated effort: 4-6 hours for preventative fix + tests
Priority: Medium (improves UX, prevents duplicate entries)

PR ambient-code#301 submitted an assessment for dbasunag's fork instead of the
official opendatahub-io/opendatahub-tests repository. The correct
submission was made in PR ambient-code#314.

This removes the incorrect submission to avoid duplicate/confusing
entries in the leaderboard.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@kami619 kami619 marked this pull request as ready for review February 23, 2026 21:56
@github-actions
Copy link
Contributor

📈 Test Coverage Report

Branch Coverage
This PR 66.1%
Main 66.1%
Diff ✅ +0%

Coverage calculated from unit tests only

@kami619 kami619 merged commit e6aecf8 into ambient-code:main Feb 23, 2026
11 of 12 checks passed
@kami619 kami619 deleted the fix/remove-incorrect-dbasunag-opendatahub-tests-submission branch February 23, 2026 22:08
github-actions bot pushed a commit that referenced this pull request Feb 23, 2026
## [2.29.2](v2.29.1...v2.29.2) (2026-02-23)

### Bug Fixes

* **cli:** check .pre-commit-config.yaml for conventional commit ([#310](#310)) ([61c44d9](61c44d9))
* remove incorrect dbasunag/opendatahub-tests submission ([#321](#321)) ([e6aecf8](e6aecf8)), closes [#301](#301)
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.29.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant