-
Notifications
You must be signed in to change notification settings - Fork 88
feat(runner): optional MLflow tracing parallel to Langfuse #1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0045719
feat(runner): optional MLflow tracing parallel to Langfuse
etirelli d361577
fix(runner): extract assistant text without claude_agent_sdk in tests
b8aedc5
fix(operator,runner): address review comments on MLflow observability
dc49508
feat(runner): wire MLflow k8s auth, SA mount, and experiment RBAC
0b93eea
fix(operator,runner): honor SecretKeyRef env precedence; tighten obse…
2e73e0d
fix(runner): restore legacy LANGFUSE_MASK_MESSAGES default; add stric…
36d3a45
refactor(runner): drop LANGFUSE_MASK_MESSAGES strict mode
6d55d13
fix(operator): delete copied observability secrets when stopping session
8d0e56c
fix: remove duplicate MLFLOW_TRACKING_AUTH and protect operator-manag…
ad3c68c
fix(operator): scope SA token automount to kubernetes-namespaced auth…
85a197e
fix(operator): handle both kubernetes auth types and fix gofmt
16e534a
fix(operator): cleanup observability secrets on Creating→Stopped path
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
25 changes: 25 additions & 0 deletions
25
components/manifests/base/ambient-admin-mlflow-observability-secret.yaml.example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Example: platform-wide MLflow tracing credentials for the operator to copy into session namespaces. | ||
| # Apply to the operator namespace (same pattern as ambient-admin-langfuse-secret). | ||
| # | ||
| # kubectl create secret generic ambient-admin-mlflow-observability-secret -n <operator-ns> \ | ||
| # --from-literal=MLFLOW_TRACING_ENABLED=true \ | ||
| # --from-literal=MLFLOW_TRACKING_URI=https://mlflow.example.com \ | ||
| # --from-literal=MLFLOW_EXPERIMENT_NAME=ambient-code-sessions \ | ||
| # --from-literal=OBSERVABILITY_BACKENDS=langfuse,mlflow | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # | ||
| # Keys: | ||
| # MLFLOW_TRACING_ENABLED - "true" to enable secret copy + runner env injection | ||
| # MLFLOW_TRACKING_URI - required on the runner for MLflow tracing | ||
| # MLFLOW_EXPERIMENT_NAME - optional (runner default: ambient-code-sessions) | ||
| # OBSERVABILITY_BACKENDS - optional; comma list: langfuse, mlflow (runner default: langfuse only if unset) | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: ambient-admin-mlflow-observability-secret | ||
| namespace: CHANGE_ME_OPERATOR_NAMESPACE | ||
| type: Opaque | ||
| stringData: | ||
| MLFLOW_TRACING_ENABLED: "true" | ||
| MLFLOW_TRACKING_URI: "https://mlflow.example.com" | ||
| MLFLOW_EXPERIMENT_NAME: "ambient-code-sessions" | ||
| OBSERVABILITY_BACKENDS: "langfuse,mlflow" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.