Skip to content

fix: improve amber-issue-handler UX (eyes reaction, comments, session links)#1268

Merged
Gkrumbach07 merged 1 commit intomainfrom
improve-amber-issue-handler
Apr 10, 2026
Merged

fix: improve amber-issue-handler UX (eyes reaction, comments, session links)#1268
Gkrumbach07 merged 1 commit intomainfrom
improve-amber-issue-handler

Conversation

@ambient-code
Copy link
Copy Markdown
Contributor

@ambient-code ambient-code bot commented Apr 9, 2026

Summary

  • Eyes reaction: Added 👀 reaction when the GitHub Action acknowledges a @ambient-code comment or ambient-code:auto-fix label, giving instant visual feedback that processing has started
  • Better issue comments: Post an immediate acknowledgement comment before session creation (not after), and improve the post-session comment to include a clickable session link instead of a raw UUID
  • Fix broken session links: Replaced literal $PLATFORM_HOST/$AGENTIC_SESSION_NAMESPACE/$AGENTIC_SESSION_NAME in prompt templates with <SESSION_URL> placeholder and explicit instructions for agents to resolve environment variables before writing URLs

Test plan

  • Label an issue with ambient-code:auto-fix and verify 👀 reaction appears on the issue
  • Verify immediate "Amber is working on this issue" comment appears before session starts
  • Verify post-session comment includes a clickable session link
  • Comment @ambient-code on a PR and verify 👀 reaction appears on the comment
  • Check that session links in PR bodies and comments resolve to actual URLs (not literal $VAR names)

Closes #1267

🤖 Generated with Claude Code


🤖 Ambient Session

Summary by CodeRabbit

  • Enhancements
    • Issues and comments now receive immediate feedback reactions
    • "Amber is working…" status comment added when processing begins
    • Improved session link handling and display in completion comments with fallback logic

… and session link fix

- Add 👀 reaction to acknowledge @ambient-code comments and auto-fix label events
- Post immediate acknowledgement comment on issues before session creation
- Improve post-session comment with clickable session link instead of raw UUID
- Fix broken session links by instructing agents to resolve env vars before
  writing URLs (replaces literal $PLATFORM_HOST/$AGENTIC_SESSION_NAMESPACE
  in markdown links with explicit resolution instructions)

Closes #1267

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ambient-code ambient-code bot added the ambient-code:managed PR managed by AI automation label Apr 9, 2026
@ambient-code
Copy link
Copy Markdown
Contributor Author

ambient-code bot commented Apr 9, 2026

All three improvements from #1267 are implemented in this PR:

  1. Eyes reaction (lines 45-50, 202-208): Immediately reacts with 👀 to acknowledge label events and @ambient-code comments
  2. Immediate comment (lines 73-80): Posts "Amber is working on this issue" before session creation, then updates with a clickable session link after completion
  3. Session link fix (all prompts): Replaced raw $VAR references in link templates with <SESSION_URL> placeholder and added explicit "Session URL" section instructing agents to resolve env vars before writing URLs

🤖 Session

@Gkrumbach07
Copy link
Copy Markdown
Contributor

Gkrumbach07 commented Apr 9, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

@Gkrumbach07 Sure, I'll review the PR!

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

📝 Walkthrough

Walkthrough

The workflow now posts immediate GitHub eyes reactions to acknowledge @ambient-code comment processing, adds an early "Amber is working" status comment, and fixes broken session links by replacing literal environment variable syntax with <SESSION_URL> placeholders resolved via environment-variable fallback construction logic.

Changes

Cohort / File(s) Summary
Workflow eyes reactions and comment improvements
.github/workflows/amber-issue-handler.yml
Added early eyes reactions to issues and comments for processing acknowledgement. Restructured comment posting with immediate "Amber is working" status message before session completes. Fixed session link format in prompt templates from literal $PLATFORM_HOST/projects/$AGENTIC_SESSION_NAMESPACE/sessions/$AGENTIC_SESSION_NAME to <SESSION_URL> placeholder, with instructions for URL resolution via steps.session.outputs.session-url fallback or constructed URL from PLATFORM_HOST and AMBIENT_PROJECT environment variables.

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Performance And Algorithmic Complexity ❌ Error batch-pr-fixer exhibits critical N+1 API call pattern: 7-8 calls per PR × 200 PRs = 1,400+ requests per 30-min batch, consuming 28%+ of GitHub's rate limit with no parallelization, caching, or backoff logic. Consolidate GitHub queries via GraphQL (1-2 calls), add exponential backoff, parallelize with matrix strategy, implement early termination filters, and cache Ambient API lookups.
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title follows Conventional Commits format (fix: scope: description) and accurately summarizes the three main changes: eyes reaction, comments, and session links.
Linked Issues check ✅ Passed All three objectives from #1267 are implemented: eyes reactions added for comments/labels [1], immediate acknowledgement comment with clickable session link [2], session link variable expansion fixed via <SESSION_URL> placeholder and resolution instructions [3].
Out of Scope Changes check ✅ Passed All changes are scoped to .github/workflows/amber-issue-handler.yml and directly address the three requirements from #1267; no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Security And Secret Handling ✅ Passed Workflow properly implements GitHub Actions security best practices with all secrets using ${{ secrets.XXX }} pattern, no hardcoded credentials, proper API authentication with Bearer tokens and GITHUB_TOKEN, safely quoted variable expansion preventing injection attacks, and no sensitive data leaks in logs or responses.
Kubernetes Resource Safety ✅ Passed Kubernetes Resource Safety check is not applicable; PR modifies only GitHub Actions workflow file, not Kubernetes manifests.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch improve-amber-issue-handler
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch improve-amber-issue-handler

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/amber-issue-handler.yml (1)

87-87: 🛠️ Refactor suggestion | 🟠 Major

Pin ambient-code/ambient-action to commit SHA across all four uses (lines 87, 260, 327, 392).

Version tags (@v0.0.5) can be force-pushed, creating supply-chain risk. Replace with the commit SHA for each tag reference. Per coding guidelines: "Pin action versions to SHA."

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/amber-issue-handler.yml at line 87, Find every occurrence
of the string uses: ambient-code/ambient-action@v0.0.5 (all four places) and
replace the tag with the corresponding exact commit SHA reference (uses:
ambient-code/ambient-action@<full-commit-sha>) so the action is pinned to an
immutable SHA; ensure you update all four occurrences consistently and verify
each SHA matches the repository commit for the v0.0.5 release before committing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In @.github/workflows/amber-issue-handler.yml:
- Line 87: Find every occurrence of the string uses:
ambient-code/ambient-action@v0.0.5 (all four places) and replace the tag with
the corresponding exact commit SHA reference (uses:
ambient-code/ambient-action@<full-commit-sha>) so the action is pinned to an
immutable SHA; ensure you update all four occurrences consistently and verify
each SHA matches the repository commit for the v0.0.5 release before committing.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c4af8a6a-7763-411e-8825-ded0033908c4

📥 Commits

Reviewing files that changed from the base of the PR and between d5555f7 and ecb04da.

📒 Files selected for processing (1)
  • .github/workflows/amber-issue-handler.yml

@Gkrumbach07 Gkrumbach07 merged commit 0f68aa9 into main Apr 10, 2026
15 checks passed
@Gkrumbach07 Gkrumbach07 deleted the improve-amber-issue-handler branch April 10, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ambient-code:managed PR managed by AI automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve amber-issue-handler.yml: eyes reaction, better comments, fix session links

1 participant