fix(make): offer to install kind via dnf on Fedora#1305
Merged
mergify[bot] merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
When `kind` is not found, `make kind-up` and `check-kind` now detect dnf-based systems and interactively offer `sudo dnf install kind` instead of just bailing out. macOS (brew) and other Linux (go install) hints are preserved. If the user declines or installation fails, the original error path with the quick-start URL still fires. Closes #620 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
@ambient-code can you functionally test this code change in your session? |
Contributor
|
I've tested it locally and it works on Fedora. |
ktdreyer
approved these changes
Apr 14, 2026
Merge Queue Status
This pull request spent 25 seconds in the queue, including 4 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make kind-upandmake check-kindnow interactively offer to installkindviasudo dnf install kindinstead of just bailing out with an error.Closes #620
Test plan
kindinstalled, runmake kind-upand verify it prompts to install via dnfkindgets installed, thenkind-upcontinuesbrew install kindhint is still shown (no dnf prompt)go installhint is still shown🤖 Generated with Claude Code
🤖 Ambient Session