add jq and gh to claude code runner#362
Conversation
Signed-off-by: Michael Clifford <mcliffor@redhat.com>
This comment has been minimized.
This comment has been minimized.
|
Looks obviously sane but #364 is a much bigger attempt to fix things like this. |
Claude Code ReviewSummaryThis PR adds jq and gh CLI tools to the claude-code-runner container. The change is straightforward and adds useful utilities for JSON processing and GitHub operations within runner pods. However, there are minor style and documentation issues to address. Overall Assessment: Approve with minor fixes recommended Issues by SeverityMinor Issues1. Trailing Whitespace (Line 8)
2. Missing Documentation
3. GitHub CLI Authentication Consideration
Positive Highlights
RecommendationsPriority 1 (Should fix before merge):
Priority 2 (Nice to have):
Additional ContextSecurity Review: No concerns - Both jq and gh are from official Debian repositories. Runner pods already have AllowPrivilegeEscalation: false and Capabilities: Drop: ALL (sessions.go:444-447) Performance Review: No concerns - Additional packages add ~5-10MB to image size (negligible for python:3.11-slim base) Testing: No tests needed - CI will verify the Dockerfile builds successfully Verdict: This is a good quality-of-life improvement. The only blocker is the trailing whitespace on line 8. |
Quality of life update that adds jq and gh to the claude code runner.