[Amber] Fix: Prevent session creation when API keys are not configured#627
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Open
Conversation
Add validation in CreateSession handler to check for ambient-runner-secrets before allowing session creation. This prevents sessions from being created and then failing during job creation with unclear error messages. Changes: - Check for ambient-runner-secrets existence in CreateSession handler - Return 400 Bad Request with clear error message when secret is missing - Skip validation when CLAUDE_CODE_USE_VERTEX=1 (Vertex AI enabled) - Add test cases for missing API key scenarios - Update existing tests to create runner secrets before creating sessions Fixes #626 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
github-actions
bot
added
amber-generated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Fix by Amber Agent
This PR addresses issue #626 using the Amber background agent.
Changes Summary
Pre-merge Checklist
Reviewer Notes
This PR was automatically generated. Please review:
🤖 Generated with Amber Background Agent
Closes #626