feat(frontend): replace custom components with shadcn/ui equivalents#778
Merged
Gkrumbach07 merged 13 commits intoambient-code:mainfrom Mar 5, 2026
Merged
Conversation
Daily scheduled triage of open issues via ACP session using the triage workflow from ambient-code/workflows. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Audit and migrate frontend to use standard shadcn/ui components, replacing hand-rolled implementations with maintained Radix-based primitives. Removes ~1,574 lines of custom code. Replaced: - Custom Breadcrumbs → shadcn Breadcrumb - Hand-rolled Popover (202 lines with portal/positioning) → Radix Popover (48 lines) - Radix Toast/Toaster/useToast → Sonner (simpler API, toast() function) - SimpleDataTable → TanStack Table DataTable with sorting/filtering/column visibility Added: - Command palette (Cmd+K) with project search and navigation - Sheet drawer for mobile navigation - Sidebar layout for workspace pages - Collapsible sections in settings and session creation - HoverCard previews on session names - Standardized Pagination component with page number display Deleted: - breadcrumbs.tsx, simple-data-table.tsx, toast.tsx, toaster.tsx, use-toast.tsx Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Combine shadcn/ui migration (Sonner toast, HoverCard icons) with upstream artifact-count column (NotepadText icon, useWorkspaceList). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Pre-push hooks caught trailing whitespace, missing final newlines, ruff formatting, and an unused variable (F841) in bridge.py. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Closed
Integrate upstream changes (runner rename to ambient-runner, runner types refactoring, admin runtimes page, model discovery) while preserving shadcn/ui component migration (sonner toasts, shadcn Breadcrumb, radix-based Dialog/Popover). Convert new upstream pages to use shadcn components for consistency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix ruff: ambiguous variable name, unused assignment, import order - Fix golangci-lint errcheck: handle Close() return values in ambient-sdk - Fix bash unbound variable in go-vet.sh and golangci-lint.sh by initializing associative arrays (empty + set -u incompatibility) - Add ambient-sdk/generator to GO_MODULES list in pre-commit scripts Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The production overlay github-app-secret.yaml contains PEM header placeholders (not actual keys) that trigger the detect-private-key pre-commit hook. Exclude it to allow pushes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…myeder/platform into jeder/shadcn-component-eval
This was referenced Mar 4, 2026
Contributor
Author
ss_.2026-03-04.at.17.33.09.movdemo |
Gkrumbach07
reviewed
Mar 4, 2026
Contributor
Author
There was a problem hiding this comment.
ah crap - part of how i was evaluating these shadcn changes was to build a page to show them all. harmless but not intended to include
jeremyeder
force-pushed
the
jeder/shadcn-component-eval
branch
from
5b06afe to
5acb5a3
Compare
This reverts commit 6628c2e.
jeremyeder
force-pushed
the
jeder/shadcn-component-eval
branch
from
5c7319c to
9017d68
Compare
8 tasks
Contributor
Author
|
Closing this PR in favor of #816 which has a cleaner commit history (single commit instead of multiple merges and reverts). |
Contributor
Author
|
Rebased branch to a clean single commit on top of current main (047314a). The messy merge history has been cleaned up. Previous commit history had 11 commits with multiple merges and a revert. Now it's a single clean commit: |
Merge Readiness — Blockers Found
|
Gkrumbach07
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: RHOAIENG-51883
hey, this came from looking into new shadcn components to improve the UI - it found several clean-ups. I've been running this patchset, it's not massively different visually but it does align a few things with the shadcn defaults.
The command palette is really awesome actually.
Summary
Test plan
🤖 Generated with Claude Code