RHOAIENG-51548: fix: replace dev-* Makefile targets with local-*

[mprpic]

The CRC-based dev-* targets (dev-logs, dev-start, dev-stop, etc.) were replaced with local-* equivalents in 5553056 but docs were never updated to reflect this changes.

[ambient-code]

Merge Readiness — Blockers Found

Check	Status	Detail
CI	pass	—
Merge conflicts	FAIL	Has merge conflicts
Review comments	pass	Has comments — agent to evaluate
Jira hygiene	pass	—
Staleness	pass	—
Diff overlap risk	—	—

This comment is auto-generated by the PR Overview workflow and will be updated when the PR changes.

[github-actions]

Claude Code Review

Summary

This is a documentation-only PR that updates stale references from the old dev-* Makefile targets to their local-* replacements across READMEs, developer guides, and Mermaid architecture diagrams. The changes are consistent and accurate throughout all seven affected files. No code, security, or architectural concerns are in scope — this is a clean housekeeping fix.

Issues by Severity

Blocker Issues

None

Critical Issues

None

Major Issues

None

Minor Issues

1. Retained DEV_MODE=true mention may be stale — crc.md:131

The Hot-Reloading workflow block was correctly updated to use local-rebuild, but the Features checklist immediately below it still reads:

- Hot-reloading with `DEV_MODE=true`

If DEV_MODE=true is no longer supported or relevant to the local-* targets, this line should be updated (e.g., to - Rebuild with \make local-rebuild`) to avoid misleading developers who consult this guide. If DEV_MODE=trueis still a valid flag for the new targets, a brief explanation of how it interacts withlocal-up` would help.

---

2. Inline # Note: comment inside a shell code block — docs/internal/developer/local-development/README.md

The replacement line reads:

make local-up    # Note: CRC dev-* targets have been replaced with local-* equivalents

Shell comments in code blocks are easy to miss and look like command syntax rather than editorial context. A Markdown callout block would be more visible and more conventional for this repo's style:

> **Note:** The old `dev-*` Makefile targets were replaced with `local-*` equivalents in commit 5553056.

Or the comment could simply be dropped — the PR itself carries that context, and the command stands alone without explanation.

Positive Highlights

• Comprehensive and consistent sweep. All seven files with stale dev-* references were found and updated, including the Mermaid .mmd diagram sources, which are easy to overlook. No partial fixes.
• Diagram fidelity preserved. The deployment-stack.mmd correctly retains LocalUp --> CRC and LocalUp --> MK arrows, reflecting that local-up supports both backends — not just minikube.
• Accurate command mapping. The local-reload-backend / frontend / operator granular targets were added to the README where the old dev-sync monolith was documented, giving readers a more precise picture of the current tooling.

Recommendations

1. Verify whether DEV_MODE=true is still valid for any local-* target; update or remove the mention in crc.md accordingly.
2. Consider converting the inline # Note: comment to a Markdown callout or removing it entirely for cleaner code examples.

🤖 Generated with Claude Code

---

🔍 View AI decision process (logs available for 90 days)

📋 View memory system files loaded (click to expand)

What Amber Loaded for Code Review

Amber automatically loaded these repository standards from the memory system:

1. CLAUDE.md - Master project instructions, development standards
2. backend-development.md - Go backend, K8s integration patterns
3. frontend-development.md - NextJS, Shadcn UI, React Query patterns
4. security-standards.md - Auth, RBAC, token handling
5. k8s-client-usage.md - User token vs service account patterns
6. error-handling.md - Consistent error patterns
7. react-query-usage.md - Data fetching patterns

Impact: This review used your repository's specific code quality standards, security patterns, and best practices from the memory system (PRs #359, #360) - not just generic code review guidelines.