merge queue: embarking main (24980cb) and #900 together#905
Closed
mergify[bot] wants to merge 6 commits intomainfrom
Closed
merge queue: embarking main (24980cb) and #900 together#905mergify[bot] wants to merge 6 commits intomainfrom
mergify[bot] wants to merge 6 commits intomainfrom
Conversation
Kind is the recommended local development tool and matches CI. CRC remains available for OpenShift-specific testing. The CI workflow now uses kind instead of minikube. The Makefile "local-up", "local-down", "local-clean", and "local-rebuild" targets are now aliases for their kind equivalents, so existing muscle memory still works. Fixes #898 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Kind requires cluster names to match "^[a-z0-9.-]+$". In CI, "git rev-parse --abbrev-ref HEAD" returns "HEAD" (detached), producing "ambient-HEAD" which kind rejects. Pipe through "tr A-Z a-z" before sanitizing so the slug is always lowercase. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The "kubectl wait --for=condition=ready" step already validates the backend pod's readiness probe (which hits /health). The explicit "wget" check fails in ubi-minimal containers that lack wget, and is redundant with the readiness gate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The comprehensive test script assumed minikube-specific behavior (DISABLE_AUTH, local-dev-user, ingress-nginx, local-reload-* targets). Update all tests to match the kind overlay setup: - Check pod readiness instead of curling via minikube IP - Accept missing ingress-nginx (kind uses NodePort mapping) - Check for NAMESPACE/PORT/BACKEND_URL env vars instead of DISABLE_AUTH - Validate test-user SA instead of local-dev-user - Test kind-rebuild instead of removed local-reload-* targets - Pass CONTAINER_ENGINE to make local-status in CI Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Bump KIND_VERSION from v0.27.0 to v0.31.0 so the CI workflow matches the "kindest/node:v1.35.0" image used in setup-kind.sh. Node images are only officially supported with the kind version they shipped with. Rename the "MK" Mermaid node identifier to "KIND" in the deployment-stack diagram, since the node now represents Kind rather than Minikube. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (24980cb) and #900 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #900.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:#approved-reviews-by >= 1[🛡 GitHub repository ruleset ruleprotect-main]#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset ruleprotect-main]Required conditions to stay in the queue:
#approved-reviews-by >= 1[🛡 GitHub repository ruleset ruleprotect-main]#approved-reviews-by>=1#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset ruleprotect-main]#changes-requested-reviews-by=0check-success=End-to-End Testscheck-success=test-local-dev-simulationcheck-success=validate-manifestscommented-reviews-by=coderabbitai[bot]