fix(backend): fix ExtractServiceAccountFromAuth unit test#910
Merged
Gkrumbach07 merged 1 commit intomainfrom Mar 13, 2026
Merged
fix(backend): fix ExtractServiceAccountFromAuth unit test#910Gkrumbach07 merged 1 commit intomainfrom
Gkrumbach07 merged 1 commit intomainfrom
Conversation
The test was setting an Authorization header via SetValidTestToken, but ExtractServiceAccountFromAuth reads the X-Remote-User header (OpenShift OAuth proxy format). Set the correct header so the test exercises the actual code path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughTest setup modification in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExtractServiceAccountFromAuthtest was failing because it set anAuthorizationheader viaSetValidTestToken, but the function reads theX-Remote-Userheader (OpenShift OAuth proxy formatsystem:serviceaccount:<ns>:<name>)X-Remote-Userheader directly instead of usingSetValidTestTokenTest plan
go test -v -tags=test ./handlers🤖 Generated with Claude Code