-
Notifications
You must be signed in to change notification settings - Fork 72
feat(frontend): redesign session detail page — remove sidebar, add explorer panel and shared layout #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(frontend): redesign session detail page — remove sidebar, add explorer panel and shared layout #939
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,141 @@ | ||
| "use client"; | ||
|
|
||
| import { useEffect, useMemo } from "react"; | ||
| import { useParams, useRouter, usePathname } from "next/navigation"; | ||
| import { PanelLeft, Plug, LogOut } from "lucide-react"; | ||
| import Link from "next/link"; | ||
| import { useVersion } from "@/services/queries/use-version"; | ||
| import { | ||
| DropdownMenu, | ||
| DropdownMenuContent, | ||
| DropdownMenuItem, | ||
| DropdownMenuTrigger, | ||
| } from "@/components/ui/dropdown-menu"; | ||
| import { Button } from "@/components/ui/button"; | ||
| import { ThemeToggle } from "@/components/theme-toggle"; | ||
| import { UserBubble } from "@/components/user-bubble"; | ||
| import { cn } from "@/lib/utils"; | ||
| import { useLocalStorage } from "@/hooks/use-local-storage"; | ||
| import { SessionsSidebar } from "./sessions/[sessionName]/components/sessions-sidebar"; | ||
|
|
||
| export default function ProjectLayout({ | ||
| children, | ||
| }: { | ||
| children: React.ReactNode; | ||
| }) { | ||
| const params = useParams(); | ||
| const router = useRouter(); | ||
| const pathname = usePathname(); | ||
| const projectName = params?.name as string; | ||
|
|
||
| // Extract session name from URL: /projects/{name}/sessions/{sessionName} | ||
| const currentSessionName = useMemo(() => { | ||
| if (!pathname) return ""; | ||
| const match = pathname.match(/\/sessions\/([^/]+)/); | ||
| return match ? decodeURIComponent(match[1]) : ""; | ||
| }, [pathname]); | ||
| const [sidebarVisible, setSidebarVisible] = useLocalStorage( | ||
| "session-sidebar-visible", | ||
| true | ||
| ); | ||
| const { data: version } = useVersion(); | ||
|
|
||
| const handleLogout = () => { | ||
| window.location.href = '/oauth/sign_out'; | ||
| }; | ||
|
|
||
| // Persist last visited project for redirect on next visit | ||
| useEffect(() => { | ||
| if (projectName) { | ||
| try { localStorage.setItem("selectedProject", projectName); } catch {} | ||
| } | ||
| }, [projectName]); | ||
|
|
||
| if (!projectName) return null; | ||
|
|
||
| return ( | ||
| <div className="absolute inset-0 overflow-hidden bg-background flex flex-col"> | ||
| <div className="flex-grow overflow-hidden bg-card flex"> | ||
| {/* Left sidebar */} | ||
| <div | ||
| className={cn( | ||
| "h-full overflow-hidden border-r transition-[width] duration-200 ease-in-out flex-shrink-0", | ||
| sidebarVisible ? "w-[300px]" : "w-0 border-r-0" | ||
| )} | ||
| > | ||
| <div className="h-full w-[280px]"> | ||
| <SessionsSidebar | ||
| projectName={projectName} | ||
| currentSessionName={currentSessionName} | ||
| collapsed={false} | ||
| onCollapse={() => setSidebarVisible(false)} | ||
| /> | ||
| </div> | ||
| </div> | ||
|
|
||
| {/* Main content */} | ||
| <div className="flex-1 min-w-0 flex flex-col h-full"> | ||
| {/* Content header with nav items */} | ||
| <div className="flex-shrink-0 border-b bg-background/95 backdrop-blur supports-[backdrop-filter]:bg-background/60"> | ||
| <div className="flex h-14 items-center justify-between gap-3 px-4"> | ||
| {/* Left: branding when sidebar is collapsed */} | ||
| <div className="flex items-center gap-2"> | ||
| {!sidebarVisible && ( | ||
| <> | ||
| <Button | ||
| variant="ghost" | ||
| size="sm" | ||
| onClick={() => setSidebarVisible(true)} | ||
| className="h-8 w-8 p-0" | ||
| title="Show sessions sidebar" | ||
| > | ||
| <PanelLeft className="h-4 w-4" /> | ||
| </Button> | ||
| <Link href="/" className="flex items-end gap-2"> | ||
| <span className="text-lg font-bold">Ambient Code Platform</span> | ||
| {version && ( | ||
| <span className="text-[0.65rem] text-muted-foreground/60 pb-0.5"> | ||
| {version} | ||
| </span> | ||
| )} | ||
| </Link> | ||
| </> | ||
| )} | ||
| </div> | ||
|
|
||
| {/* Right: nav items */} | ||
| <div className="flex items-center gap-3"> | ||
| <ThemeToggle /> | ||
| <Button | ||
| variant="ghost" | ||
| size="sm" | ||
| onClick={() => router.push('/integrations')} | ||
| className="text-muted-foreground hover:text-foreground" | ||
| > | ||
| <Plug className="w-4 h-4 mr-1" /> | ||
| Integrations | ||
| </Button> | ||
| <DropdownMenu> | ||
| <DropdownMenuTrigger className="outline-none"> | ||
| <UserBubble /> | ||
| </DropdownMenuTrigger> | ||
| <DropdownMenuContent align="end"> | ||
| <DropdownMenuItem onSelect={handleLogout}> | ||
| <LogOut className="w-4 h-4 mr-2" /> | ||
| Logout | ||
| </DropdownMenuItem> | ||
| </DropdownMenuContent> | ||
| </DropdownMenu> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| {/* Page content */} | ||
| <div className="flex-1 overflow-auto"> | ||
| {children} | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| "use client"; | ||
|
|
||
| import { useCallback, useState } from "react"; | ||
| import { useParams, useRouter } from "next/navigation"; | ||
| import { toast } from "sonner"; | ||
| import { NewSessionView } from "../sessions/[sessionName]/components/new-session-view"; | ||
| import { CustomWorkflowDialog } from "../sessions/[sessionName]/components/modals/custom-workflow-dialog"; | ||
| import { useCreateSession } from "@/services/queries"; | ||
| import { useOOTBWorkflows } from "@/services/queries/use-workflows"; | ||
|
|
||
| export default function NewSessionPage() { | ||
| const params = useParams(); | ||
| const router = useRouter(); | ||
| const projectName = params?.name as string; | ||
|
|
||
| const { data: ootbWorkflows = [] } = useOOTBWorkflows(projectName); | ||
| const createSessionMutation = useCreateSession(); | ||
| const [customWorkflowDialogOpen, setCustomWorkflowDialogOpen] = useState(false); | ||
| const [customWorkflow, setCustomWorkflow] = useState<{ gitUrl: string; branch: string; path: string } | null>(null); | ||
|
|
||
| const handleCreateNewSession = useCallback( | ||
| (config: { | ||
| prompt: string; | ||
| runner: string; | ||
| model: string; | ||
| workflow?: string; | ||
| repos?: Array<{ url: string }>; | ||
| }) => { | ||
| const workflowConfig = config.workflow === "custom" && customWorkflow | ||
| ? { gitUrl: customWorkflow.gitUrl, branch: customWorkflow.branch, path: customWorkflow.path } | ||
| : config.workflow | ||
| ? ootbWorkflows.find((w) => w.id === config.workflow) | ||
| : undefined; | ||
|
|
||
| createSessionMutation.mutate( | ||
| { | ||
| projectName, | ||
| data: { | ||
| initialPrompt: config.prompt, | ||
| runnerType: config.runner, | ||
| llmSettings: { model: config.model }, | ||
| ...(workflowConfig | ||
| ? { | ||
| activeWorkflow: { | ||
| gitUrl: workflowConfig.gitUrl, | ||
| branch: workflowConfig.branch || "main", | ||
| path: workflowConfig.path, | ||
| }, | ||
| } | ||
| : {}), | ||
| ...(config.repos && config.repos.length > 0 | ||
| ? { | ||
| repos: config.repos.map((r) => ({ url: r.url })), | ||
| } | ||
| : {}), | ||
| }, | ||
| }, | ||
| { | ||
| onSuccess: (session) => { | ||
| router.push( | ||
| `/projects/${encodeURIComponent(projectName)}/sessions/${session.metadata.name}` | ||
| ); | ||
| }, | ||
| onError: (err) => { | ||
| toast.error( | ||
| err instanceof Error | ||
| ? err.message | ||
| : "Failed to create session" | ||
| ); | ||
| }, | ||
| } | ||
| ); | ||
| }, | ||
| [projectName, ootbWorkflows, customWorkflow, createSessionMutation, router] | ||
| ); | ||
|
|
||
| if (!projectName) return null; | ||
|
|
||
| return ( | ||
| <div className="h-full overflow-auto"> | ||
| <NewSessionView | ||
| projectName={projectName} | ||
| onCreateSession={handleCreateNewSession} | ||
| ootbWorkflows={ootbWorkflows} | ||
| onLoadCustomWorkflow={() => setCustomWorkflowDialogOpen(true)} | ||
| isSubmitting={createSessionMutation.isPending} | ||
| /> | ||
| <CustomWorkflowDialog | ||
| open={customWorkflowDialogOpen} | ||
| onOpenChange={setCustomWorkflowDialogOpen} | ||
| onSubmit={(url, branch, path) => { | ||
| setCustomWorkflow({ gitUrl: url, branch: branch || "main", path: path || "" }); | ||
| setCustomWorkflowDialogOpen(false); | ||
| }} | ||
| /> | ||
| </div> | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.