Skip to content

make rpm for fedora or other flavors of linux#304

Closed
harrisonvanderbyl wants to merge 1 commit intoamd:mainfrom
harrisonvanderbyl:main
Closed

make rpm for fedora or other flavors of linux#304
harrisonvanderbyl wants to merge 1 commit intoamd:mainfrom
harrisonvanderbyl:main

Conversation

@harrisonvanderbyl
Copy link
Copy Markdown

Idk, it just needs some if statements in there tbh

@AMDGithubSCIMAdmin
Copy link
Copy Markdown

Can one of the admins verify this patch?

@harrisonvanderbyl
Copy link
Copy Markdown
Author

There was a couple dependencies I needed to manually find, as they had different names, like kernel-headers and libgudev I think,
I also had to copy the .ko file over and then manually add it with insmod,
image

Comment thread tools/amdxdna_deps.sh
Comment on lines +12 to +14
elif [ -x "$(command -v dnf)" ]; then
dnf install -y jq
fi
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the other deps script of xrt uses yum instead of dnf (probably for compatibility?)

So, maybe here also use yum?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNF has been the default package manager since EL 8. How about let's not use it's legacy alias?

@lamikr
Copy link
Copy Markdown

lamikr commented Jan 9, 2025

I think it's better to add option for building the rpm in addition of deb files instead of replacing the deb-packaging with rpm packaging. This is slightly modified version of original patch that does that. I have tested it on fedora 40.

I am not sure whether we need to change the /lib/firmware/amdnpu to /usr/lib/firmware/amdnpu, so I dropped that part.

0001-make-rpm-for-fedora-or-other-flavors-of-linux.txt

@maxzhen
Copy link
Copy Markdown
Collaborator

maxzhen commented Feb 28, 2025

Finally find some time to incorporate this change as #394. Closing this one since it is obsolete now.

@maxzhen maxzhen closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants