Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring umq df_bw xrt_test #348

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Refactoring umq df_bw xrt_test #348

merged 1 commit into from
Jan 15, 2025

Conversation

hlaccabu
Copy link
Contributor

No description provided.

@hlaccabu
Refactoring umq df_bw xrt_test
e440915 
Signed-off-by: Hayden Laccabue <[email protected]>
@hlaccabu hlaccabu requested a review from mamin506 January 10, 2025 19:17
@mamin506 mamin506 requested a review from xdavidz January 10, 2025 22:49
mamin506
mamin506 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@mamin506 mamin506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is confusing. This is a bug fix to me. @xdavidz , please take a look.

@hlaccabu
Copy link
Contributor Author

The title is confusing. This is a bug fix to me. @xdavidz , please take a look.

Apologies. The xclbin was updated to have the test return the input bo instead of all 0s. The code change is for the test to reflect this.

@mamin506 mamin506 merged commit 7385e68 into amd:main Jan 15, 2025
1 check passed
@hlaccabu hlaccabu deleted the aie4_dev branch January 15, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xdavidz xdavidz xdavidz approved these changes

@mamin506 mamin506 mamin506 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hlaccabu @mamin506 @xdavidz