Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

perf(intl): lower log level for language pack cache #77

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

10xLaCroixDrinker
Copy link
Member

Description

Lower language pack cache log level from info to debug

Motivation and Context

The using cache log can be printed several times per request and when working, the setting cache logs can be very large & will repeat every 10 min. The existing setting cache log does not work since pino migration.

Removing these from the default log level used in production will improve performance as well as DX (for reviewing logs).

Closes #29

How Has This Been Tested?

  • Updated unit tests
  • Packed and installed to one-app and manually validated

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for one-app-ducks users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using one-app-ducks?

Fewer low value logs by default

Copy link
Member

@smackfu smackfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was my old bug.

@10xLaCroixDrinker 10xLaCroixDrinker merged commit a6acbba into main Mar 5, 2024
4 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the bugfix/logging branch March 5, 2024 16:12
oneamexbot added a commit that referenced this pull request Mar 5, 2024
## [4.4.4](v4.4.3...v4.4.4) (2024-03-05)

### Performance Improvements

* **intl:** lower log level for language pack cache ([#77](#77)) ([a6acbba](a6acbba))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 4.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entire language file is dumped to logs every ten minutes
4 participants