chore: testing node 20

.github/workflows/on-pr-and-trunk_one-app-unit-and-lint-tests.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [18.x, 20.10.0]
+        node-version: [18.x, 20.8.1]
     steps:
       - name: Checkout
         uses: actions/checkout@v4

.nvmrc

@@ -1 +1 @@
-20.10.0
+20.8.1

Dockerfile

@@ -1,9 +1,9 @@
-ARG VERSION=20.10.0
+ARG VERSION=lts
 # Use the pre-baked fat node image only in the builder
 # which includes build utils preinstalled (e.g. gcc, make, etc).
 # This will result in faster and reliable One App docker image
 # builds as we do not have to run apk installs for alpine.
-FROM node:$VERSION as builder
+FROM node:$VERSION-alpine as builder
 WORKDIR /opt/build
 RUN npm install -g [email protected] --registry=https://registry.npmjs.org
 COPY --chown=node:node ./ /opt/build

one-app-statics/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@americanexpress/one-app-statics",
-  "version": "6.13.0-node-20-10-0.1",
+  "version": "6.13.0-node-20-10-0.2",
   "description": "One App Static Assets",
   "main": "index.js",
   "scripts": {

package.json

@@ -1,10 +1,10 @@
 {
   "name": "@americanexpress/one-app",
-  "version": "6.13.0-node-20-10-0.1",
+  "version": "6.13.0-node-20-10-0.2",
   "description": "One Amex SPA technology stack.",
   "main": "index.js",
   "engines": {
-    "node": ">=18 <=20.10.0",
+    "node": ">=18 <=20.8.1",
     "npm": ">=9"
   },
   "scripts": {

prod-sample/api/Dockerfile

@@ -1,6 +1,6 @@
-ARG VERSION=20.10.0
+ARG VERSION=lts
 
-FROM node:$VERSION as builder
+FROM node:$VERSION-alpine as builder
 MAINTAINER One App Team
 
 WORKDIR /