Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

chore(workflows): use Node.js 18.x, same as the image #1089

Closed
wants to merge 3 commits into from

Conversation

PixnBits
Copy link
Contributor

Description

continue #1067: use the same major version for the workflows

Motivation and Context

increase test fidelity

How Has This Been Tested?

most will be run as PR checks, the release process might need to be after

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

none, maybe confidence in tests

@PixnBits PixnBits requested review from a team as code owners August 14, 2023 20:25
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

Size Change: 0 B

Total Size: 689 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 164 kB
./build/app/app~vendors.js 389 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.26 kB
./build/app/vendors.js 122 kB

compressed-size-action

@PixnBits
Copy link
Contributor Author

consider #1090 for a longer-term improvement

@PixnBits PixnBits requested a review from a team August 14, 2023 22:23
Copy link
Member

@code-forger code-forger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this superseded entirely by #1090 ?

@JAdshead
Copy link
Contributor

closing for #1090

@JAdshead JAdshead closed this Aug 31, 2023
@Matthew-Mallimo Matthew-Mallimo deleted the feature/node18-workflows branch March 21, 2024 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants