Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

chore(workflows): use Node.js 18.x, same as the image #1089

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Runs CodeQL against the PR code
### [on PR, Trunk] One App Unit and Lint Tests
Runs One App's unit tests and linting tests against the PR code

This workflow creates two checks, one for node 14 and one for node 16.
This workflow creates checks, one for each of Node.js 16.x and 18.x.

### [on PR] DangerJS
Runs dangerJS against the PR code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bundle-size.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- uses: preactjs/compressed-size-action@v2
env:
NODE_ENV: development
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, "^18 < 18.16"]
node-version: [16.x, 18.x]
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/on-pr_dangerJS.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: '16.x'
node-version: '18.x'
- uses: actions/cache@v3
with:
path: ~/.npm
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/on-pr_one-app-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
${{ runner.os }}-node-
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: npm install
run: NODE_ENV=development npm ci
- name: Build docker image
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
${{ runner.os }}-node-
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: One App release
id: vars
run: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
# Setup .npmrc file to publish to npm
- uses: actions/setup-node@v3
with:
node-version: '16.x'
node-version: '18.x'
registry-url: 'https://registry.npmjs.org'
- name: Docker login
run: echo "${{ secrets.DOCKER_PASSWORD }}" | docker login --username ${{ secrets.DOCKER_USER }} --password-stdin
Expand Down
Loading