Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Enable OpenTelemetry logging in v6 #1097

Merged
merged 23 commits into from
Sep 22, 2023
Merged

Conversation

10xLaCroixDrinker
Copy link
Member

Builds on #1084, pairs with #1059

Description

Added otel transport

Motivation and Context

Enable logs to be sent to OTel collector.

There is a bug that is currently blocking instrumentation, and a limitation on the otel transport that required a bit of a hack for sending otel logs to console in development. (Both documented in code comments)

How Has This Been Tested?

Ran locally with prod sample sending logs to local collector. Yet to test in higher environments. Hold merging until then

  • testing in higher environments complete

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Adds ability to use open telemetry for logs

@10xLaCroixDrinker 10xLaCroixDrinker requested review from a team as code owners August 23, 2023 22:11
@10xLaCroixDrinker 10xLaCroixDrinker changed the title Enable OpenTelemetry in v6 Enable OpenTelemetry logging in v6 Aug 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

Size Change: 0 B

Total Size: 710 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 164 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 121 kB

compressed-size-action

@Matthew-Mallimo Matthew-Mallimo requested a review from a team August 24, 2023 20:51
Base automatically changed from feature/fastify-logging to main September 5, 2023 21:38
@10xLaCroixDrinker 10xLaCroixDrinker merged commit a0b8cb6 into main Sep 22, 2023
7 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/enable-otel-in-v6 branch September 22, 2023 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants