Skip to content

chore: limit packed files#56

Closed
smackfu wants to merge 1 commit intomainfrom
limit-packed-files
Closed

chore: limit packed files#56
smackfu wants to merge 1 commit intomainfrom
limit-packed-files

Conversation

@smackfu
Copy link
Copy Markdown
Member

@smackfu smackfu commented Nov 11, 2024

Description

Currently a bunch of junk is in the packed tar.gz like tests and github actions.

This changes to only include the lib dir plus other npm defaults.

$ npm pack

> @americanexpress/vitruvius@3.0.1 prepare
> husky install

husky - Git hooks installed
npm notice
npm notice 📦  @americanexpress/vitruvius@3.0.1
npm notice Tarball Contents
npm notice 10.3kB LICENSE.txt
npm notice 2.6kB README.md
npm notice 1.3kB lib/collectBuiltState.js
npm notice 1.5kB lib/immutable.js
npm notice 1.3kB lib/index.js
npm notice 2.0kB package.json

This decreases the size from 17.9kb packed to 6.5kb.

Copy link
Copy Markdown
Contributor

@10xLaCroixDrinker 10xLaCroixDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead use an .npmignore?

@smackfu
Copy link
Copy Markdown
Member Author

smackfu commented Nov 15, 2024

Can you instead use an .npmignore?

This article makes it seem like files is better?
https://medium.com/@jdxcode/for-the-love-of-god-dont-use-npmignore-f93c08909d8d

@github-actions
Copy link
Copy Markdown
Contributor

This pull request is stale because it has been open 30 days with no activity.

@smackfu
Copy link
Copy Markdown
Member Author

smackfu commented Dec 23, 2024

#57 conflicts with this.

@smackfu smackfu closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants